From 35ed31ce8e6f281a027df955b3251f5002875420 Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+studip@gmail.com>
Date: Tue, 25 Apr 2023 09:02:19 +0000
Subject: [PATCH] align sorting display and remove obsolete icons, fixes #2580

Closes #2580

Merge request studip/studip!1737
---
 public/assets/images/dreieck_down.png         | Bin 1272 -> 0 bytes
 public/assets/images/dreieck_down@2x.png      | Bin 1362 -> 0 bytes
 public/assets/images/dreieck_up.png           | Bin 1283 -> 0 bytes
 public/assets/images/dreieck_up@2x.png        | Bin 1344 -> 0 bytes
 resources/assets/stylesheets/less/tables.less |  25 ++++++++++--------
 5 files changed, 14 insertions(+), 11 deletions(-)
 delete mode 100644 public/assets/images/dreieck_down.png
 delete mode 100644 public/assets/images/dreieck_down@2x.png
 delete mode 100644 public/assets/images/dreieck_up.png
 delete mode 100644 public/assets/images/dreieck_up@2x.png

diff --git a/public/assets/images/dreieck_down.png b/public/assets/images/dreieck_down.png
deleted file mode 100644
index 1b3eb528cede821e2d8a9b6d638aa75a32a3583a..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 1272
zcmeAS@N?(olHy`uVBq!ia0y~yU=RRd4mJh`2Kmqb6B!s7BuiW)N`mv#O3D+9QW+dm
z@{>{(JaZG%Q-e|yQz{EjrrIztFso#SM3hAM`dB6B=jtVb)aX^@7BGN-jeSKyVsdtB
zi9%9pdS;%j()-=}l@u~lY?Z=IeGPmIoKrJ0J*tXQgRA^PlB=?lEmM^2?G$V(tSWK~
za#KqZ6)JLb@`|l0Y?Z*~TICg6frRyy6u?SKvTc<hj*9RNP;kyKN>wn`GuBNuFf>#!
zGt)CPF*P$Y)KM@pFf`IPFw!?L(={})GBvX@GFN~CB|8P1qLehNAQv~NT}3Hrwn`Z#
zB?VUc`sL;2dgaD?`9<mahL)C=ATx}Nbc<5bbc-wVN)jt{^NN*WCb*;)Cl_TFlw{`T
zDS%8&Ov*1Uu~kxn8e5TD05>+T7#d8;`MLTPi3R$GdIlgbLHwFq;OmQDX>KlDb#X~h
zD#E>34K5C;EJ)Q4N-fSWElN%eN=;J+xv9X)xhOTUB)=#mKR*W+iUAq<CHch}`2`Bj
z!Db2?zKO}1c_0Bzunu2eE6=>*lEl2^R8JRMrHb4Fz0AxMD;Gm^CnF<g69W@7M?*tb
zV@D@f3s+YQHzx}>Ll-9tXP91>{N&Qy)Vvay-jvJ~D>n;EV<#s!1Dtw6i2)QKRxYVU
znPsUdZbkXI3SduLW#V>=5l-`<dQ-5t1?mrDoO<=`6m0ZCQHvDSFrgq9HxLt?DnTjK
zP63hhQ}a@6m5P+??Y?O4i(_D5%<^<`45_%4^ymM7duG*!&PJyLO=osiJYIR=dcM8y
zjF~h4J-Do_u30f{cK2Ufd4Bd)jNy6q$!FKZZfu!7*;l5Yaed9)5?&!E9mzF3qJeuK
zq%8aw73#QUZf9p_WB25@@>Xd{Nhucsre#<cKfU<*{{H_)i7kv5(%K^GKOa?Uy2Jnf
z-`{p6_D82ZIPQgp3&sEW_E+4^Fmc|03ATnmPhPM2?H4np{7`@VgM@?@FT<uEPE0X>
zYi!=UFFSKS@j}S7AN{6c|Ni_vy+BQWn~R&%1I7zsZY$pQIQ-L9jhwi2-L+W-XCrt6
z!bQ?In1@#@YaKCud47I<!fi*B3HM(otowHGYE*N9)rHFwk{&#N8pH7AK<ox{3CVQ~
zKfN6vxu~j4&~7mNbnje9>Z|SV_e-qlom#~$Ja=Eykxsu(w_BTdY+~M=Zul3^`Q>+1
zB4ggANk-b*#?0*OuUBjGK0J9~%1>9<IFZ#>#~9E1h)6RCBrtHdmgb)Q;}8QXi#%QZ
KT-G@yGywpi1k02F

diff --git a/public/assets/images/dreieck_down@2x.png b/public/assets/images/dreieck_down@2x.png
deleted file mode 100644
index c11d6889e2f69cb599d6010e3608d94c4249b501..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 1362
zcmeAS@N?(olHy`uVBq!ia0y~yU{C;I4mJh`hT^KKFANL}k|nMYCBgY=CFO}lsSJ)O
z`AMk?p1FzXsX?iUDV2pMQ*9U+m{l@EB1$5BeXNr6bM+EIYV;~{3m8Da#=fE;F*!T6
zL?J0PJu}Z%>HY5gN(z}Nwo2iqz6QPp&Z!xh9#uuD!Bu`C$yM3OmMKd1b_zBXRu#Dg
zxv3?I3Kh9IdBs*0wn|`gt@4VkK*IV;3ScEA*|tg$M@9GsC^+XAr7D=}8S5q+7#b>=
znduptn3|ax>L?f)7#ist80j0B=^C0?nVMM{nJYknlAVH0QA(Oskc%7CuA-DQTcwPW
zk^(Dz{qpj1y>er{{GxPyLrY6bkQqisx<x5zy2X`wC5aWfdBw^w6I@b@lZ!G7N;32F
z6hI~>Cgqow*eWSOjjhNnfE$}v3=O8_{9OHt!~%UoJp+)JAb!m)@b$&7G&dKny0|1L
z72#g21{a4^7NqJ2r55Lx7A2<!rKTx^+*DxYT$Gwvl3x^(pPvH@#ej_blKkR~`~n5%
zU^4{`-^Aq1Jdl7USck8#m1kaYNn&1ds;7&sQblfoUS?*Bm79g7v6GXVv4M%1qoJXz
zv7?i#g{!NDo0El`p^KA+Gfb~besXDUYF-IUZwf-M2~NGB!~hBqE0@%w%(B!Jx1#)9
z1+b^BGI6`b5T|)iy(zfeVuVw#zMX=NJ}7FDq8cU?<l+Wmf>R|Zh1w|~l74Dlimg(S
zlD*vv?oD9~42(xST^vIyZoQedU!TQM<aqvd*(h5su6m}mzq$W#N{KGj5P4$J>$O-(
zDT=jKxHUth?wZG(XC5I!jw*NhKURJ;+nLih`{wP_rq(CT^V8Fx{jJMCW_)akmF1t1
zcK1aN$3;E<Z#9?``$b`Uf(o0ZKfn4;#)@wa``6eUaMSF!RM>KjDdmhC??J;I`3H+W
zK9aRKQguI)anA?NlkR6k{U^4cw>Ejars3H^yB&QCTISd?v;HV?=W2Y?n6;mG-_(_B
zKN#J3@@MrqRryutQZ?clPFl^+@8hy5%Ip3tDH@X)w^8qKfa!@DOx1jfGs3c@ILoqJ
zW^s!@xbvuI&HN_qvwyO5<_c)fQ{3$<@#~hk*^U1~pAsHN+>AROF<C6!soQ96woxLh
z-c56@jqTGO@8M=@+^P1v>FcV{ZM$qdOqT6^z{ay`_u-A_yEa9{XCKea*kXOI-OFgj
zZ_%?A*{f}?tIw=j$S>1i$lLqJnn`$3$J(!f_nF;{YutAyPx!gI=;|(x|4-Z4V+>99
zU0Aw>g-7GXo${xmUtL9x<hs2qdQrbB*D~O`B<tS<p*4;C>ECbPVg3J<pUL}zYGx3h
pc<5_6k9ki!nL3#Y`{Wtf7#>a(vF)ol$^$CpJYD@<);T3K0RUQ3>B;~A

diff --git a/public/assets/images/dreieck_up.png b/public/assets/images/dreieck_up.png
deleted file mode 100644
index eefd3e09c79bb421e40367dc235317f1c93cbfe7..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 1283
zcmeAS@N?(olHy`uVBq!ia0y~yU=RRd4mJh`2Kmqb6B!s7BuiW)N`mv#O3D+9QW+dm
z@{>{(JaZG%Q-e|yQz{EjrrIztFso#SM3hAM`dB6B=jtVb)aX^@7BGN-jeSKyVsdtB
zi9%9pdS;%j()-=}l@u~lY?Z=IeGPmIoKrJ0J*tXQgRA^PlB=?lEmM^2?G$V(tSWK~
za#KqZ6)JLb@`|l0Y?Z*~TICg6frRyy6u?SKvTc<hj*9RNP;kyKN>wn`GuBNuFf>#!
zGt)CPF*P$Y)KM@pFf`IPFw!?L(={})GBvX@GFN~CB|8P1qLehNAQv~NT}3Hrwn`Z#
zB?VUc`sL;2dgaD?`9<mahL)C=ATx}Nbc<5bbc-wVN)jt{^NN*WCb*;)Cl_TFlw{`T
zDS%8&Ov*1Uu~kxn8e5TD05>+T7#d8;`MLTPi3R$GdIlgbLHwFq;OmQDX>KlDb#X~h
zD#E>34K5C;EJ)Q4N-fSWElN%eN=;J+xv9X)xhOTUB)=#mKR*W+iUAq<CHch}`2`Bj
z!Db2?zKO}1c_0Bzunu2eE6=>*lEl2^R8JRMrHb4Fz0AxMD;Gm^CnF;#X9E*6M?*tb
zV@D@f3s+YQHzx}>Ll-9tXP91>{N&Qy)Vvay-V}sh7o2)Qi2)QKRxYVUnPsUdZbkXI
z3SduLW#V>=BTn<6dQ)(_#R;cgeLDpkeNfaQMKw$)$i)rB1gA<+3bj)}B>mL96kDYt
zC40NC%lJ<+Fff*Sx;TbZ+)DcM|Gz!6YC~tEQ^Vzk@ALN=#_aq%=i&AD`+3CkZH{I#
zaO-tum&X}|e9cKoPERfr7JqoxY^UCz`3&;vAN78G{mtLJc<HR0KePSCR-Ne1+*|c~
zW`%yu&u^0xe>bk?S-oxE>BkA_f>Ara<~%&7eEq;97s-N0hnU;Aug{OD`}fPZVQ%kK
zMi2LO_bUVWRs1eA@Xz08d}rVPuFk1bcRsnlzkbbu47Q;E7M7NgryCwgtUJJQ<oSAg
zqnsPX7iA<m_Q||ilVB)N`|{Z43HSH^_pA8*@%7AEI{bI^e*E~!uB@!=ta+kL;k$f@
z#1pPEJ-=;}*59u)N;6-R^5@T2_GOIc<Li@N%-()oCSx}LnKB86kLTkmWePsu^Zwjh
zt@n3-!Cy_`Ht~CPKTg&B_%e6beuvxpYybBr9=yN*|Bdzc>f+Wf(|E@I<ljMq2Txjm
zUwZb7OXp6^8}@(33C{%G6#jhvuJ7Hjdf%E3h3~c-Zag^abA+jZftjJ_#wN4+XN$E#
O#geD1pUXO@geCyo0O3>s

diff --git a/public/assets/images/dreieck_up@2x.png b/public/assets/images/dreieck_up@2x.png
deleted file mode 100644
index 165dc6c1a52a288d784f1765849f298fab2133ac..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 1344
zcmeAS@N?(olHy`uVBq!ia0y~yU{C;I4mJh`hT^KKFANL}k|nMYCBgY=CFO}lsSJ)O
z`AMk?p1FzXsX?iUDV2pMQ*9U+m{l@EB1$5BeXNr6bM+EIYV;~{3m8Da#=fE;F*!T6
zL?J0PJu}Z%>HY5gN(z}Nwo2iqz6QPp&Z!xh9#uuD!Bu`C$yM3OmMKd1b_zBXRu#Dg
zxv3?I3Kh9IdBs*0wn|`gt@4VkK*IV;3ScEA*|tg$M@9GsC^+XAr7D=}8S5q+7#b>=
znduptn3|ax>L?f)7#ist80j0B=^C0?nVMM{nJYknlAVH0QA(Oskc%7CuA-DQTcwPW
zk^(Dz{qpj1y>er{{GxPyLrY6bkQqisx<x5zy2X`wC5aWfdBw^w6I@b@lZ!G7N;32F
z6hI~>Cgqow*eWSOjjhNnfE$}v3=O8_{9OHt!~%UoJp+)JAb!m)@b$&7G&dKny0|1L
z72#g21{a4^7NqJ2r55Lx7A2<!rKTx^+*DxYT$Gwvl3x^(pPvH@#ej_blKkR~`~n5%
zU^4{`-^Aq1Jdl7USck8#m1kaYNn&1ds;7&sQblfoUS?*Bm5ZUdlaZ0Lfq{vcqoJXz
zv7?i#g{!NDo0El`p^KA+Gfb~besXDUYF-IUZwf-MAx^!Z!~hBqE0@%w%(B!Jx1#)9
z1+b^BGI6@a$rY!0P`xQQ-QwhiQ?I_Af{i{XYLTKECKTl224aF!B`Ag3DIk)5YF>)1
zQjwCq-JzNOnhXq#n><|{Ln>~)nP%&KI6$Or@|HRUy*$6r0LM8pYvh|1LPbheT5$Ju
z&E7p_ozkNPlOOmO6cwy$ZeBe5!GrvQK*wmQ`ONA9PTu)N&Rr9@`P-Mg-1~gb`;&VM
zYwwr;vb0%#UfKUay_!Mj%AEl`vEmCSq^w)y`YBgTSCIdKklp4j2Ws=L+&)sd;_#f9
zZljs13qE>1&U~`(r%R!^(#lC$wT~ux*>f13wE8Z;*~1}3y16=HT3mpt`~oiDt?ISh
zTdHQ(Xm8metih07SgkmXDeAAm9w$$6KJm{iqMm0$SoP06vU(}!<04ib(i?gsM0C#<
zU5<HczgFn|*gGML=~Zoa#i6GuCw}`aK2!YL=Dtbb!4>RVRvvq(cd6!X*QB@`t^6Ck
z;-a-#OPW-hj~?C|aBZGuM5I8~(!8X1hSwWURYmMH6O$3vOIYCiz5Mp7=z<Qe?SJY$
zrV3g|9plWnw)jE=EA!9Auj~$+)v!Nj;rt^Jz2IKBu#ViDKJ5*MZT5HGV-k^2+;d>d
z(Um{hx<9Cj9SdsM$Y?AkuN!oC&5aAW+25*u)GrII5IbSv|JLH%{;tm~pI9!*)id!h
Yd<$8%b4h&1RZyAc>FVdQ&MBb@00(2?^Z)<=

diff --git a/resources/assets/stylesheets/less/tables.less b/resources/assets/stylesheets/less/tables.less
index 3018062f1b2..6eab679e5cc 100644
--- a/resources/assets/stylesheets/less/tables.less
+++ b/resources/assets/stylesheets/less/tables.less
@@ -649,14 +649,15 @@ table.withdetails {
         display: inline-block;
         height: 16px;
         margin-left: 0;
-        .retina-background-image('dreieck_@{direction}.png', 'dreieck_@{direction}@2x.png', 16px, 16px);
-        vertical-align: text-top;
+        .background-icon('arr_1@{direction}');
+        vertical-align: text-bottom;
         width: 16px;
     }
 }
 
 .sortable-table {
-    .header, .tablesorter-header:not(.sorter-false) {
+    .header,
+    .tablesorter-header:not(.sorter-false) {
         white-space: nowrap;
 
         color: @base-color;
@@ -664,18 +665,20 @@ table.withdetails {
             color: @active-color;
             cursor: pointer;
         }
+        &.tablesorter-headerDesc:hover .tablesorter-header-inner::after {
+            .background-icon('arr_1down', 'status-red');
+        }
+        &.tablesorter-headerAsc:hover .tablesorter-header-inner::after {
+            .background-icon('arr_1up', 'status-red');
+        }
     }
-    .headerSortUp, .tablesorter-headerDesc .tablesorter-header-inner {
+    .headerSortUp,
+    .tablesorter-headerDesc .tablesorter-header-inner {
         .sortable-dreieck('down');
-        &::after {
-            vertical-align: inherit;
-        }
     }
-    .headerSortDown, .tablesorter-headerAsc .tablesorter-header-inner {
+    .headerSortDown,
+    .tablesorter-headerAsc .tablesorter-header-inner {
         .sortable-dreieck('up');
-        &::after {
-            vertical-align: inherit;
-        }
     }
     .tablesorter-headerUnSorted:not(.sorter-false) .tablesorter-header-inner {
         margin-right: 15px;
-- 
GitLab