From 31e6680a953fb9faf595ff971b30500c4ffee678 Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+studip@gmail.com>
Date: Thu, 2 Nov 2023 13:51:32 +0000
Subject: [PATCH] let skiplinks navigation be a nav element, fixes #2642, fixes
#2645
Closes #2642 and #2645
Merge request studip/studip!1802
---
lib/include/html_head.inc.php | 2 +-
templates/layouts/base.php | 2 +-
templates/skiplinks.php | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/include/html_head.inc.php b/lib/include/html_head.inc.php
index f1108ce7536..7e7bdea9711 100644
--- a/lib/include/html_head.inc.php
+++ b/lib/include/html_head.inc.php
@@ -62,5 +62,5 @@ $lang_attr = str_replace('_', '-', $_SESSION['_language']);
</head>
<body id="<?= PageLayout::getBodyElementId() ?>">
- <div id="skip_link_navigation" aria-busy="true"></div>
+ <nav id="skip_link_navigation" aria-busy="true"></nav>
<?= PageLayout::getBodyElements() ?>
diff --git a/templates/layouts/base.php b/templates/layouts/base.php
index 67bb2b92f52..8dc2444c0ca 100644
--- a/templates/layouts/base.php
+++ b/templates/layouts/base.php
@@ -71,7 +71,7 @@ $lang_attr = str_replace('_', '-', $_SESSION['_language']);
</head>
<body id="<?= PageLayout::getBodyElementId() ?>" <? if (!PageLayout::isSidebarEnabled()) echo 'class="no-sidebar"'; ?>>
- <div id="skip_link_navigation" aria-busy="true"></div>
+ <nav id="skip_link_navigation" aria-busy="true"></nav>
<?= PageLayout::getBodyElements() ?>
<? include 'lib/include/header.php' ?>
diff --git a/templates/skiplinks.php b/templates/skiplinks.php
index dcea66b0825..28758de8ccc 100644
--- a/templates/skiplinks.php
+++ b/templates/skiplinks.php
@@ -2,7 +2,7 @@
# Lifter010: TODO
?>
<? if ($navigation instanceof Navigation && iterator_count($navigation) > 0) : ?>
- <ul role="navigation" id="skiplink_list">
+ <ul id="skiplink_list">
<? foreach ($navigation as $index => $nav) : ?>
<li>
<? if (mb_substr($url = $nav->getURL(), 0, 1) == '#') : ?>
--
GitLab