From 2ffa7291ea24eb1f8cc710e45e30f2f0b411636f Mon Sep 17 00:00:00 2001
From: David Siegfried <david.siegfried@uni-vechta.de>
Date: Sat, 11 Mar 2023 15:39:46 +0000
Subject: [PATCH] prevent php-warnings, closes #2356
Closes #2356
Merge request studip/studip!1540
---
app/controllers/admin/courses.php | 4 +++-
lib/models/Semester.class.php | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/app/controllers/admin/courses.php b/app/controllers/admin/courses.php
index 49703ead3c6..99b2943c6d8 100644
--- a/app/controllers/admin/courses.php
+++ b/app/controllers/admin/courses.php
@@ -1193,7 +1193,9 @@ class Admin_CoursesController extends AuthenticatedController
$filter->filterBySemester($this->semester->getId());
}
if ($active_elements['courseType'] && $params['typeFilter'] && $params['typeFilter'] !== "all") {
- list($class_filter,$type_filter) = explode('_', $params['typeFilter']);
+ $parts = explode('_', $params['typeFilter']);
+ $class_filter = $parts[0];
+ $type_filter = $parts[1] ?? null;
if (!$type_filter && !empty($GLOBALS['SEM_CLASS'][$class_filter])) {
$type_filter = array_keys($GLOBALS['SEM_CLASS'][$class_filter]->getSemTypes());
}
diff --git a/lib/models/Semester.class.php b/lib/models/Semester.class.php
index 6934563e97b..21481f2f394 100644
--- a/lib/models/Semester.class.php
+++ b/lib/models/Semester.class.php
@@ -243,7 +243,7 @@ class Semester extends SimpleORMap
$semesters = self::getAllAsArray($with_before_first);
}
foreach ($semesters as $index => $semester) {
- if (@$semester['semester_id'] === $semester_id) {
+ if (isset($semester['semester_id']) && $semester['semester_id'] === $semester_id) {
return $index;
}
}
--
GitLab