From 29211afb76b10e0ec6b83203bdbc23181186bc4b Mon Sep 17 00:00:00 2001 From: Jan-Hendrik Willms <tleilax+studip@gmail.com> Date: Wed, 1 Mar 2023 09:20:02 +0000 Subject: [PATCH] fixes #2230 Closes #2230 Merge request studip/studip!1460 --- app/views/course/feedback/index.php | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/app/views/course/feedback/index.php b/app/views/course/feedback/index.php index fe4c83fffa6..44805346ca2 100644 --- a/app/views/course/feedback/index.php +++ b/app/views/course/feedback/index.php @@ -1,3 +1,9 @@ +<?php +/** + * @var Course_FeedbackController $controller + * @var FeedbackElement[] $feedback_elements + */ +?> <? if (empty($feedback_elements)): ?> <?= MessageBox::info(_('Es wurden noch keine Feedback-Elemente angelegt.')) ?> <? else: ?> @@ -51,7 +57,7 @@ <tr> <td data-sort-value="<?= crc32($feedback->range_type) ?>" class="responsive-hidden"> <a href="<?= $controller->link_for($range->getRangeUrl()) ?>" - title="<?= $range->getRangeName() ?>"> + title="<?= htmlReady($range->getRangeName()) ?>"> <?= $range->getRangeIcon('clickable') ?> </a> </td> @@ -83,9 +89,9 @@ <?= _('Kommentar') ?> <? endif; ?> </td> - <td data-sort-value="<?= $feedback->user->getFullName('no_title_rev') ?>" class="responsive-hidden"> - <a href="<?= URLHelper::getLink('dispatch.php/profile?username=' . $feedback->user->username) ?>"> - <?= $feedback->user->getFullName('no_title_rev') ?> + <td data-sort-value="<?= htmlReady($feedback->user->getFullName('no_title_rev')) ?>" class="responsive-hidden"> + <a href="<?= URLHelper::getLink('dispatch.php/profile', ['username' => $feedback->user->username]) ?>"> + <?= htmlReady($feedback->user->getFullName('no_title_rev')) ?> </a> </td> <td title="<?= strftime('%x %X', $feedback->chdate) ?>" data-sort-value="<?= $feedback->chdate ?>"> -- GitLab