From 28be9e0d255e56a4af9d0e3a22189cbf62b93d67 Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+studip@gmail.com>
Date: Fri, 18 Oct 2024 08:48:27 +0000
Subject: [PATCH] ensure forum likes and options are posted, fixes #4692

Closes #4692

Merge request studip/studip!3489
---
 app/controllers/calendar/schedule.php  |  4 ++--
 app/controllers/course/forum/index.php |  8 ++++++++
 app/views/course/forum/index/_like.php | 19 ++++++++++---------
 3 files changed, 20 insertions(+), 11 deletions(-)

diff --git a/app/controllers/calendar/schedule.php b/app/controllers/calendar/schedule.php
index 33c9f6dd00b..c1652f7e6b7 100644
--- a/app/controllers/calendar/schedule.php
+++ b/app/controllers/calendar/schedule.php
@@ -58,7 +58,7 @@ class Calendar_ScheduleController extends AuthenticatedController
                 _('Ausgeblendete Veranstaltungen verstecken'),
                 $this->indexURL(['semester_id' => Request::get('semester_id')]),
                 Icon::create('visibility-invisible')
-            );
+            )->asButton();
         } else {
             $actions->addLink(
                 _('Ausgeblendete Veranstaltungen anzeigen'),
@@ -67,7 +67,7 @@ class Calendar_ScheduleController extends AuthenticatedController
                     'semester_id' => Request::get('semester_id'),
                 ]),
                 Icon::create('visibility-visible')
-            );
+            )->asButton();
         }
 
         $actions->addLink(
diff --git a/app/controllers/course/forum/index.php b/app/controllers/course/forum/index.php
index bb1b49cb25e..d3be08ebe79 100644
--- a/app/controllers/course/forum/index.php
+++ b/app/controllers/course/forum/index.php
@@ -561,6 +561,10 @@ class Course_Forum_IndexController extends ForumController
      */
     function like_action($topic_id)
     {
+        if (!Request::isPost()) {
+            throw new MethodNotAllowedException();
+        }
+
         ForumPerm::check('like_entry', $this->getId(), $topic_id);
 
         ForumLike::like($topic_id);
@@ -580,6 +584,10 @@ class Course_Forum_IndexController extends ForumController
      */
     function dislike_action($topic_id)
     {
+        if (!Request::isPost()) {
+            throw new MethodNotAllowedException();
+        }
+
         ForumPerm::check('like_entry', $this->getId(), $topic_id);
 
         ForumLike::dislike($topic_id);
diff --git a/app/views/course/forum/index/_like.php b/app/views/course/forum/index/_like.php
index 6d11acbfadd..da1c5115d1e 100644
--- a/app/views/course/forum/index/_like.php
+++ b/app/views/course/forum/index/_like.php
@@ -36,12 +36,13 @@ shuffle($likes);
 endif ?>
 
 <!-- like/dislike links -->
-<? if (!in_array($GLOBALS['user']->id, $likes)) : ?>
-    <a href="<?= $controller->link_for('course/forum/index/like/'. $topic_id) ?>" onClick="jQuery('#like_<?= $topic_id ?>').load('<?= $controller->link_for('course/forum/index/like/'. $topic_id) ?>'); return false;">
-        <?= _('Gefällt mir!'); ?>
-    </a>
-<? else : ?>
-    <a href="<?= $controller->link_for('course/forum/index/dislike/'. $topic_id) ?>" onClick="jQuery('#like_<?= $topic_id ?>').load('<?= $controller->link_for('course/forum/index/dislike/'. $topic_id) ?>'); return false;">
-        <?= _('Gefällt mir nicht mehr!'); ?>
-    </a>
-<? endif ?>
+<?php $has_liked = in_array($GLOBALS['user']->id, $likes); ?>
+<button class="as-link"
+        onclick="$.post('<?= $controller->action_link($has_liked ? 'dislike' : 'like', $topic_id) ?>').done(response => $('#like_<?= htmlReady($topic_id) ?>').html(response));return false;"
+>
+<? if ($has_liked) : ?>
+    <?= _('Gefällt mir nicht mehr!'); ?>
+<? else: ?>
+    <?= _('Gefällt mir!'); ?>
+<? endif; ?>
+</button>
-- 
GitLab