From 208b2f9f4e201c2924a98e9cbdb4c1c243f2294d Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+studip@gmail.com>
Date: Fri, 10 Feb 2023 14:34:41 +0000
Subject: [PATCH] fix url generation, fixes #2156

Closes #2156

Merge request studip/studip!1392
---
 app/controllers/module/module.php | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/app/controllers/module/module.php b/app/controllers/module/module.php
index 996ec7651a4..f8c99174c8c 100644
--- a/app/controllers/module/module.php
+++ b/app/controllers/module/module.php
@@ -914,7 +914,7 @@ class Module_ModuleController extends MVVController
                     ));
                 }
             }
-            $this->redirect($this->detailsURL($this->modulteil->modul_id . '/' . $this->modulteil->id));
+            $this->redirect($this->detailsURL($this->modulteil->modul_id, $this->modulteil->id));
         }
     }
 
@@ -936,7 +936,7 @@ class Module_ModuleController extends MVVController
                 $lvg_modulteil->delete();
             }
         }
-        $this->redirect($this->detailsURL($modulteil->modul_id . '/' . $modulteil->id));
+        $this->redirect($this->detailsURL($modulteil->modul_id, $modulteil->id));
     }
 
     public function lvgruppe_action($modulteil_id, $lvgruppe_id = null)
@@ -960,7 +960,7 @@ class Module_ModuleController extends MVVController
                     $this->lvgruppe->getDisplayName());
             }
             $this->cancel_url = $this->indexURL();
-            $this->submit_url = $this->lvgruppeURL($this->modulteil->id . '/' . $this->lvgruppe->id);
+            $this->submit_url = $this->lvgruppeURL($this->modulteil->id, $this->lvgruppe->id);
             if (Request::submitted('store')) {
                 CSRFProtection::verifyUnsafeRequest();
                 $stored = false;
@@ -990,7 +990,7 @@ class Module_ModuleController extends MVVController
                     } else {
                         PageLayout::postInfo(_('Es wurden keine Änderungen vorgenommen.'));
                     }
-                    $this->relocate($this->detailsURL($this->modulteil->modul_id . '/' . $this->modulteil->id));
+                    $this->relocate($this->detailsURL($this->modulteil->modul_id, $this->modulteil->id));
                     return;
                 }
             }
@@ -1100,7 +1100,7 @@ class Module_ModuleController extends MVVController
             if (Request::isXhr()) {
                 $this->response->add_header(
                     'X-Location',
-                    $this->diffURL($new_module->id . '/' . $old_module->id)
+                    $this->diffURL($new_module->id, $old_module->id)
                 );
             }
             $type_new = 1;
-- 
GitLab