From 205b1e60c00e62dca444f740e9b847bd2380f1fb Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+studip@gmail.com>
Date: Wed, 25 Jan 2023 14:30:39 +0000
Subject: [PATCH] prevent warning in OpenGraphURL, fixes #2068
Closes #2068
Merge request studip/studip!1344
---
lib/models/OpenGraphURL.class.php | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/models/OpenGraphURL.class.php b/lib/models/OpenGraphURL.class.php
index 5df5e7f1030..19ea6146e0a 100644
--- a/lib/models/OpenGraphURL.class.php
+++ b/lib/models/OpenGraphURL.class.php
@@ -156,6 +156,8 @@ class OpenGraphURL extends SimpleORMap
return;
}
+ $isOpenGraph = false;
+
$response = FileManager::fetchURLMetadata($this['url']);
if ($response['response_code'] == 200 && mb_strpos($response['Content-Type'],'html') !== false) {
if (preg_match('/(?<=charset=)[^;]*/i', $response['Content-Type'], $match)) {
@@ -186,7 +188,6 @@ class OpenGraphURL extends SimpleORMap
$metatags = $doc->getElementsByTagName('meta');
$reservedTags = ['url', 'chdate', 'mkdate', 'last_update', 'is_opengraph', 'data'];
- $isOpenGraph = false;
$ogTags = [];
$data = [];
foreach ($metatags as $tag) {
@@ -230,6 +231,7 @@ class OpenGraphURL extends SimpleORMap
}
$this['data'] = $data;
}
+
$this['is_opengraph'] = (int) $isOpenGraph;
}
--
GitLab