From 1488ccea6e8353d832b30fc590ab39d02c43215e Mon Sep 17 00:00:00 2001
From: Elmar Ludwig <elmar.ludwig@uni-osnabrueck.de>
Date: Thu, 14 Sep 2023 14:50:07 +0000
Subject: [PATCH] fix checks using `is_array()` (which is always true now),
fixes #3187
Closes #3187
Merge request studip/studip!2156
---
lib/classes/StudipSemSearchHelper.class.php | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/classes/StudipSemSearchHelper.class.php b/lib/classes/StudipSemSearchHelper.class.php
index bb45d24acef..29ee5d37a18 100644
--- a/lib/classes/StudipSemSearchHelper.class.php
+++ b/lib/classes/StudipSemSearchHelper.class.php
@@ -104,7 +104,7 @@ class StudipSemSearchHelper {
if (isset($this->params['type']) && $this->params['type'] != 'all'){
$sem_types = [$this->params['type']];
}
- if (!empty($sem_types) && is_array($sem_types)) {
+ if ($sem_types) {
$clause = " AND c.status IN('" . join("','",$sem_types) . "') " . $clause;
}
@@ -112,7 +112,7 @@ class StudipSemSearchHelper {
if ($this->params['scope_choose'] && $this->params['scope_choose'] != 'root'){
$sem_tree = TreeAbstract::GetInstance("StudipSemTree", false);
- $view->params[0] = (is_array($sem_types) ? $sem_types : $sem_tree->sem_status);
+ $view->params[0] = $sem_types ?: $sem_tree->sem_status;
$view->params[1] = $this->visible_only ? "c.visible=1" : "1";
$view->params[2] = $sem_tree->getKidsKids($this->params['scope_choose']);
--
GitLab