From 00e62584ae9b60c7646290d4481b71f42fce8d81 Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+studip@gmail.com>
Date: Thu, 8 Sep 2022 20:03:51 +0000
Subject: [PATCH] ensure correct return type, fixes #1548
Closes #1548
Merge request studip/studip!968
---
lib/models/AuxLockRule.php | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/models/AuxLockRule.php b/lib/models/AuxLockRule.php
index ca0f168ddbf..15d37626f62 100644
--- a/lib/models/AuxLockRule.php
+++ b/lib/models/AuxLockRule.php
@@ -19,7 +19,7 @@
* @property string description database column
* @property string attributes database column
* @property string sorting database column
- * @property string datafields computed column
+ * @property array datafields computed column
* @property string order computed column
* @property Course course belongs_to Course
*/
@@ -143,7 +143,9 @@ class AuxLockRule extends SimpleORMap
public function getMemberData($member)
{
$datafields = SimpleCollection::createFromArray(DatafieldEntryModel::findByModel($member));
- foreach ($this->datafields as $field => $useless_value_pls_refactor) {
+
+ $result = [];
+ foreach (array_keys($this->datafields) as $field) {
// since we have no only datafields we have to filter!
if ($new = $datafields->findOneBy('datafield_id', $field)) {
$result[] = $new;
--
GitLab