Probleme, die durch statische Code-Anaylse mittels PHPStan aufgefallen sind
Vermutlich muss manches noch zum Portieren in eigene BIESTer gegossen werden, aber dies ist erstmal ein Sammelticket für die Probleme.
-
app/controllers/admin/courses.php:493:Class Flex\Template not found.
-
app/controllers/admin/tree.php:195:Class PageLayout referenced with incorrect case: Pagelayout.
-
app/controllers/admin/tree.php:197:Class PageLayout referenced with incorrect case: Pagelayout.
-
app/controllers/course/admission.php:172:Undefined variable: $user_id
-
app/controllers/course/admission.php:175:Undefined variable: $user_id
-
app/controllers/course/basicdata.php:785:Undefined variable: $teacher_id
-
app/controllers/course/feedback.php:74:Array has 2 duplicate keys with value 'mode' ('mode', 'mode').
-
app/controllers/course/members.php:1180:Undefined variable: $msgs
-
app/controllers/course/members.php:1184:Undefined variable: $msgs
-
app/controllers/course/members.php:1189:Undefined variable: $msgs
-
app/controllers/course/statusgroups.php:1568:Call to an undefined static method BasicDataWizardStep::copyParticipantsAndGroups().
-
app/controllers/course/studygroup.php:294:Instantiated class Seminar not found.
-
app/controllers/course/studygroup.php:417:Instantiated class Seminar not found.
-
app/controllers/course/timesrooms.php:533:Caught class Studip\ResourceBookingException not found.
-
app/controllers/course/timesrooms.php:533:Caught class Studip\ResourceBookingOverlapException not found.
-
app/controllers/course/timesrooms.php:563:Class Studip\ResourceBookingException not found.
-
app/controllers/course/timesrooms.php:1145:Caught class Studip\ResourceBookingException not found.
-
app/controllers/course/timesrooms.php:1145:Caught class Studip\ResourceBookingOverlapException not found.
-
app/controllers/debugbar.php:2:Class DebugbarController extends unknown class Trails_Controller.
-
app/controllers/debugbar.php:8:DebugbarController::__construct() calls parent::__construct() but DebugbarController does not extend any class.
-
app/controllers/debugbar.php:13:Call to an undefined method DebugbarController::set_content_type().
-
app/controllers/debugbar.php:14:Call to an undefined method DebugbarController::render_nothing().
-
app/controllers/debugbar.php:20:Call to an undefined method DebugbarController::set_content_type().
-
app/controllers/debugbar.php:21:Call to an undefined method DebugbarController::render_nothing().
-
app/controllers/institute/basicdata.php:429:Call to static method DeleteAllConfigurations() on an unknown class ExternConfig.
-
app/controllers/my_courses.php:197:Call to static method getView() on an unknown class DbView.
-
app/controllers/resources/ajax.php:781:Instantiated class RecordNotFoundException not found.
-
app/controllers/settings/notification.php:56:Call to static method getView() on an unknown class DbView.
-
lib/classes/AdminCourseFilter.php:44:Unsafe usage of new static().
-
lib/classes/AdminCourseFilter.php:48:Unsafe usage of new static().
-
lib/classes/Avatar.php:82:Unsafe usage of new static().
-
lib/classes/Avatar.php:92:Unsafe usage of new static().
-
lib/classes/JsonApi/Middlewares/DangerousRouteHandler.php:27:Instantiated class JsonApi\Middlewares\Response not found.
-
lib/classes/JsonApi/RouteMap.php:328:Class JsonApi\Routes\Tree\CourseinfoOfTreeNode referenced with incorrect case: JsonApi\Routes\Tree\CourseInfoOfTreeNode.
-
lib/classes/JsonApi/Routes/Courseware/Rel/SolversOfTaskGroup.php:174:Instantiated class JsonApi\Routes\Courseware\Rel\RuntimeException not found.
-
lib/classes/JsonApi/Routes/Feedback/RatingHelper.php (in context of class JsonApi\Routes\Feedback\FeedbackEntriesCreate):29:Instantiated class JsonApi\Routes\Feedback\InvalidArgumentException not found.
-
lib/classes/JsonApi/Routes/Feedback/RatingHelper.php (in context of class JsonApi\Routes\Feedback\FeedbackEntriesUpdate):29:Instantiated class JsonApi\Routes\Feedback\InvalidArgumentException not found.
-
lib/classes/JsonApi/Routes/Files/FileRefsContentShow.php:18:Parameter $container of method JsonApi\Routes\Files\FileRefsContentShow::__construct() has invalid type JsonApi\Routes\Files\ContainerInterface.
-
lib/classes/JsonApi/Routes/Holidays/HolidaysShow.php:99:Access to an undefined property JsonApi\Routes\Holidays\HolidaysShow::$query_parser.
-
lib/classes/JsonApi/Routes/RangeTree/ChildrenOfRangeTreeNode.php:26:Call to static method getNode() on an unknown class JsonApi\Routes\RangeTree\RangeTreeNode.
-
lib/classes/OAuth2/NegotiatesWithPsr7.php (in context of class StudipAuthLTI):36:Call to an undefined method StudipAuthLTI::set_status().
-
lib/classes/OAuth2/NegotiatesWithPsr7.php (in context of class StudipAuthLTI):37:Call to an undefined method StudipAuthLTI::render_text().
-
lib/classes/SQLQuery.php:226:Template type T of method SQLQuery::fetchAll() is not referenced in a parameter.
-
lib/classes/SimpleORMap.php:482:Unsafe usage of new static().
-
lib/classes/SimpleORMap.php:522:Unsafe usage of new static().
-
lib/classes/SimpleORMap.php:540:Unsafe usage of new static().
-
lib/classes/SimpleORMap.php:580:Unsafe usage of new static().
-
lib/classes/StudipMail.php:84:Undefined variable: $mail_localhost
-
lib/classes/cache/Exception.php:24:Class Studip\Cache\Exception extends unknown class StudipException.
-
lib/classes/cache/Exception.php:24:Non-abstract class Studip\Cache\Exception contains abstract method __toString() from interface Throwable.
-
lib/classes/cache/Exception.php:24:Non-abstract class Studip\Cache\Exception contains abstract method getCode() from interface Throwable.
-
lib/classes/cache/Exception.php:24:Non-abstract class Studip\Cache\Exception contains abstract method getFile() from interface Throwable.
-
lib/classes/cache/Exception.php:24:Non-abstract class Studip\Cache\Exception contains abstract method getLine() from interface Throwable.
-
lib/classes/cache/Exception.php:24:Non-abstract class Studip\Cache\Exception contains abstract method getMessage() from interface Throwable.
-
lib/classes/cache/Exception.php:24:Non-abstract class Studip\Cache\Exception contains abstract method getPrevious() from interface Throwable.
-
lib/classes/cache/Exception.php:24:Non-abstract class Studip\Cache\Exception contains abstract method getTrace() from interface Throwable.
-
lib/classes/cache/Exception.php:24:Non-abstract class Studip\Cache\Exception contains abstract method getTraceAsString() from interface Throwable.
-
lib/classes/cache/InvalidCacheArgumentException.php:25:Class Studip\Cache\InvalidCacheArgumentException extends unknown class StudipException.
-
lib/classes/cache/InvalidCacheArgumentException.php:25:Non-abstract class Studip\Cache\InvalidCacheArgumentException contains abstract method __toString() from interface Throwable.
-
lib/classes/cache/InvalidCacheArgumentException.php:25:Non-abstract class Studip\Cache\InvalidCacheArgumentException contains abstract method getCode() from interface Throwable.
-
lib/classes/cache/InvalidCacheArgumentException.php:25:Non-abstract class Studip\Cache\InvalidCacheArgumentException contains abstract method getFile() from interface Throwable.
-
lib/classes/cache/InvalidCacheArgumentException.php:25:Non-abstract class Studip\Cache\InvalidCacheArgumentException contains abstract method getLine() from interface Throwable.
-
lib/classes/cache/InvalidCacheArgumentException.php:25:Non-abstract class Studip\Cache\InvalidCacheArgumentException contains abstract method getMessage() from interface Throwable.
-
lib/classes/cache/InvalidCacheArgumentException.php:25:Non-abstract class Studip\Cache\InvalidCacheArgumentException contains abstract method getPrevious() from interface Throwable.
-
lib/classes/cache/InvalidCacheArgumentException.php:25:Non-abstract class Studip\Cache\InvalidCacheArgumentException contains abstract method getTrace() from interface Throwable.
-
lib/classes/cache/InvalidCacheArgumentException.php:25:Non-abstract class Studip\Cache\InvalidCacheArgumentException contains abstract method getTraceAsString() from interface Throwable.
-
lib/classes/calendar/ICalendarExport.php:40:Access to an undefined property ICalendarExport::$default_filename_suffix.
-
lib/classes/calendar/ICalendarExport.php:41:Access to an undefined property ICalendarExport::$format.
-
lib/classes/calendar/ICalendarImport.php:97:Access to an undefined property ICalendarImport::$import_sem.
-
lib/classes/calendar/ICalendarImport.php:316:Class InvalidValuesException constructor invoked with 0 parameters, 1-2 required.
-
lib/classes/calendar/ICalendarImport.php:474:Class InvalidValuesException constructor invoked with 0 parameters, 1-2 required.
-
lib/classes/calendar/ICalendarImport.php:489:Class InvalidValuesException constructor invoked with 0 parameters, 1-2 required.
-
lib/classes/calendar/ICalendarImport.php:655:Access to an undefined property ICalendarImport::$client_identifier.
-
lib/classes/calendar/ICalendarImport.php:659:Class InvalidValuesException constructor invoked with 0 parameters, 1-2 required.
-
lib/classes/calendar/ICalendarImport.php:673:Access to an undefined property ICalendarImport::$client_identifier.
-
lib/classes/coursewizardsteps/BasicDataWizardStep.php:407:Call to an undefined method BasicDataWizardStep::copyBasicData().
-
lib/exTpl/IteratorNode.php:41:Undefined variable: $key
-
lib/exTpl/IteratorNode.php:41:Undefined variable: $value
-
lib/exTpl/TemplateParserException.php:17:Result of method Exception::__construct() (void) is used.
-
lib/exceptions/FeatureDisabledException.php:2:Class FeatureDisabledException extends unknown class StudipException.
-
lib/exceptions/FeatureDisabledException.php:9:FeatureDisabledException::__construct() calls parent::__construct() but FeatureDisabledException does not extend any class.
-
lib/helpers.php:25:Template type T of function app() is not referenced in a parameter.
-
lib/ilias_interface/IliasSoap.php:120:Access to an undefined property IliasSoap::$faultstring.
-
lib/ilias_interface/StudipSoapClient.php:30:Access to an undefined property StudipSoapClient::$faultstring.
-
lib/ilias_interface/studip_referrer_7x.php:16:Instantiated class ilIniFile not found.
-
lib/ilias_interface/studip_referrer_8x.php:16:Instantiated class ilIniFile not found.
-
lib/ilias_interface/studip_referrer_8x.php:119:Instantiated class ilCtrlTokenRepository not found.
-
lib/ilias_interface/studip_referrer_8x.php:121:Access to constant PARAM_CSRF_TOKEN on an unknown class ilCtrlInterface.
-
lib/models/Course.php:334:Call to static method deleteByRange_id() on an unknown class WikiPageConfig.
-
lib/models/Course.php:353:Undefined variable: $this
-
lib/models/Course.php:596:Call to an undefined static method CourseSet::countBySeminar_id().
-
lib/models/Courseware/StructuralElement.php:187:Function BadMethodCallException not found.
-
lib/models/MvvContact.php:475:Method MvvContact::logChanges() should return bool but return statement is missing.
-
lib/models/MvvContactRange.php:240:Method MvvContactRange::logChanges() should return bool but return statement is missing.
-
lib/models/MvvExternContact.php:70:Method MvvExternContact::logChanges() should return bool but return statement is missing.
-
lib/models/MvvFile.php:515:Method MvvFile::logChanges() should return bool but return statement is missing.
-
lib/models/MvvFileFileref.php:135:Method MvvFileFileref::logChanges() should return bool but return statement is missing.
-
lib/models/MvvFileRange.php:79:Method MvvFileRange::logChanges() should return bool but return statement is missing.
-
lib/models/StudipCacheOperation.php:43:Parameter $cache of method StudipCacheOperation::apply() has invalid type StudipCache.
-
lib/plugins/core/CorePlugin.php:65:Call to an undefined method CorePlugin::getMetadata().
-
tests/unit/lib/flexi/PHPTemplatePartialBugTest.php:10:Access to an undefined property PhpTemplatePartialBugTestCase::$factory.
-
tests/unit/lib/flexi/PHPTemplatePartialBugTest.php:40:Access to an undefined property PhpTemplatePartialBugTestCase::$factory.
-
tests/unit/lib/flexi/TemplateMagicMethodsTest.php:15:Access to an undefined property TemplateMagicMethodsTestCase::$template.
-
tests/unit/lib/flexi/TemplateMagicMethodsTest.php:26:Access to an undefined property TemplateMagicMethodsTestCase::$template.
-
tests/unit/lib/flexi/TemplateMagicMethodsTest.php:27:Access to an undefined property TemplateMagicMethodsTestCase::$template.
-
tests/unit/lib/flexi/TemplateMagicMethodsTest.php:32:Access to an undefined property TemplateMagicMethodsTestCase::$template.
-
tests/unit/lib/flexi/TemplateMagicMethodsTest.php:33:Access to an undefined property TemplateMagicMethodsTestCase::$template.
-
tests/unit/lib/flexi/TemplateMagicMethodsTest.php:34:Access to an undefined property TemplateMagicMethodsTestCase::$template.
-
tests/unit/lib/flexi/TemplateMagicMethodsTest.php:39:Access to an undefined property TemplateMagicMethodsTestCase::$template.
-
tests/unit/lib/flexi/TemplateMagicMethodsTest.php:40:Access to an undefined property TemplateMagicMethodsTestCase::$template.
-
tests/unit/lib/flexi/TemplateMagicMethodsTest.php:41:Access to an undefined property TemplateMagicMethodsTestCase::$template.
-
tests/unit/lib/flexi/TemplateMagicMethodsTest.php:46:Access to an undefined property TemplateMagicMethodsTestCase::$template.
-
tests/unit/lib/flexi/TemplateMagicMethodsTest.php:47:Access to an undefined property TemplateMagicMethodsTestCase::$template.
-
tests/unit/lib/flexi/TemplateMagicMethodsTest.php:52:Access to an undefined property TemplateMagicMethodsTestCase::$template.
-
tests/unit/lib/flexi/TemplateMagicMethodsTest.php:57:Access to an undefined property TemplateMagicMethodsTestCase::$template.
-
tests/unit/lib/flexi/TemplateMagicMethodsTest.php:59:Access to an undefined property TemplateMagicMethodsTestCase::$template.
-
tests/unit/lib/flexi/TemplateMagicMethodsTest.php:65:Access to an undefined property TemplateMagicMethodsTestCase::$template.
-
tests/unit/lib/flexi/TemplateMagicMethodsTest.php:70:Access to an undefined property TemplateMagicMethodsTestCase::$template.
Edited by Jan-Hendrik Willms