From d821f486a09fb5ce95f38176e5209bed7503184b Mon Sep 17 00:00:00 2001
From: Moritz Strohm <strohm@data-quest.de>
Date: Mon, 29 Nov 2021 10:31:49 +0100
Subject: [PATCH] fixed skiplink button style, added ARIA role for skiplink
buttons
---
resources/assets/stylesheets/less/skiplinks.less | 15 ++++++++-------
templates/skiplinks.php | 2 +-
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/resources/assets/stylesheets/less/skiplinks.less b/resources/assets/stylesheets/less/skiplinks.less
index 2da49110bfb..b57cdf90461 100644
--- a/resources/assets/stylesheets/less/skiplinks.less
+++ b/resources/assets/stylesheets/less/skiplinks.less
@@ -23,13 +23,14 @@
#skiplink_list {
display: none;
- button.skiplink {
- border: 0;
- background-color: #fff;
- color: @base-color;
- line-height: 1em;
- margin-bottom: 0.1em;
- }
+}
+
+button.skiplink {
+ border: 0;
+ background-color: #fff;
+ color: @base-color;
+ line-height: 1em;
+ margin-bottom: 0.1em;
}
body.enable-skiplinks {
diff --git a/templates/skiplinks.php b/templates/skiplinks.php
index b057c589ee8..3854c4c6a96 100644
--- a/templates/skiplinks.php
+++ b/templates/skiplinks.php
@@ -6,7 +6,7 @@
<? foreach ($navigation as $nav) : ?>
<li>
<? if (mb_substr($url = $nav->getURL(), 0, 1) == '#') : ?>
- <button class="skiplink" onclick="STUDIP.SkipLinks.setActiveTarget('<?= $url ?>');"><?= htmlReady($nav->getTitle()) ?></button>
+ <button class="skiplink" role="link" onclick="STUDIP.SkipLinks.setActiveTarget('<?= $url ?>');"><?= htmlReady($nav->getTitle()) ?></button>
<? else : ?>
<? if (is_internal_url($url)) : ?>
<a href="<?= URLHelper::getLink($url) ?>"><?= htmlReady($nav->getTitle()) ?></a>
--
GitLab