From d48f57dc4ba0f640d29338578aa9478019d95afb Mon Sep 17 00:00:00 2001 From: Elmar Ludwig <elmar.ludwig@uni-osnabrueck.de> Date: Fri, 4 Nov 2022 09:14:27 +0000 Subject: [PATCH] don't treat user_id as array, remove duplicate check, fixes #1743 Closes #1743 Merge request studip/studip!1135 --- app/controllers/course/basicdata.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/controllers/course/basicdata.php b/app/controllers/course/basicdata.php index a94a7a48037..8a32bc34885 100644 --- a/app/controllers/course/basicdata.php +++ b/app/controllers/course/basicdata.php @@ -625,8 +625,8 @@ class Course_BasicdataController extends AuthenticatedController $lecturers = $sem->getMembers(); foreach ($deputies as $deputy) { // ..but only if not already set as lecturer or deputy. - if (!isset($lecturers[$deputy['user_id']]) && !Deputy::isDeputy($deputy['user_id'], $course_id)) { - Deputy::addDeputy($deputy['user_id'], $course_id); + if (!isset($lecturers[$deputy])) { + Deputy::addDeputy($deputy, $course_id); } } } -- GitLab