From ccf5e6d80259f2684f48c2870671e50d64d59c3b Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+github@gmail.com>
Date: Tue, 10 May 2022 08:59:37 +0200
Subject: [PATCH] fix regression from 0d95625c2ab0eabe98e724ab79be0087093cc35b,
re #957
---
lib/phplib/Seminar_Perm.class.php | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/lib/phplib/Seminar_Perm.class.php b/lib/phplib/Seminar_Perm.class.php
index 4e8c0f82300..736c1e3bb08 100644
--- a/lib/phplib/Seminar_Perm.class.php
+++ b/lib/phplib/Seminar_Perm.class.php
@@ -101,12 +101,8 @@ class Seminar_Perm
{
$page_perm_value = $this->permissions[$perm] ?? 0;
$user_perm_value = $this->permissions[$this->get_perm($user_id)] ?? 0;
- if ($user_perm_value) {
- return $page_perm_value <= $user_perm_value;
- } else {
- //The user has no permissions at all.
- return false;
- }
+
+ return $page_perm_value <= $user_perm_value;
}
@@ -297,12 +293,8 @@ class Seminar_Perm
$pageperm = $this->permissions[$perm] ?? 0;
$userperm = $this->permissions[$this->get_profile_perm($range_id, $user_id)] ?? 0;
- if ($userperm) {
- return $pageperm <= $userperm;
- } else {
- //The user has no permissions at all.
- return false;
- }
+
+ return $pageperm <= $userperm;
}
/**
--
GitLab