From bb333e511b9a85794c50bbd802bb59361898feba Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+studip@gmail.com>
Date: Thu, 4 Apr 2024 08:16:00 +0000
Subject: [PATCH] disallow turning a regular course into a study group, fixes
#3921
Closes #3921
Merge request studip/studip!2797
---
app/controllers/course/basicdata.php | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/app/controllers/course/basicdata.php b/app/controllers/course/basicdata.php
index e0611ed62c8..62385e435d3 100644
--- a/app/controllers/course/basicdata.php
+++ b/app/controllers/course/basicdata.php
@@ -956,20 +956,30 @@ class Course_BasicdataController extends AuthenticatedController
private function _getTypes($sem, $data, &$changable = true)
{
$sem_types = [];
+
+ $sem_classes = [];
if ($GLOBALS['perm']->have_perm("admin")) {
foreach (SemClass::getClasses() as $sc) {
if (!$sc['course_creation_forbidden']) {
- $sem_types[$sc['name']] = array_map(function ($st) {
- return $st['name'];
- }, $sc->getSemTypes());
+ $sem_classes[] = $sc;
}
}
} else {
- $sc = $sem->getSemClass();
+ $sem_classes[] = $sem->getSemClass();
+ }
+
+ if (!$sem->isStudyGroup()) {
+ $sem_classes = array_filter($sem_classes, function (SemClass $sc) {
+ return !$sc['studygroup_mode'];
+ });
+ }
+
+ foreach ($sem_classes as $sc) {
$sem_types[$sc['name']] = array_map(function ($st) {
return $st['name'];
}, $sc->getSemTypes());
}
+
if (!in_array($data['status'], array_flatten(array_values(array_map('array_keys', $sem_types))))) {
$class_name = $sem->getSemClass()->offsetGet('name');
if (!isset($sem_types[$class_name])) {
--
GitLab