From b3f6bde730cd33b2c8d296d67442c3ca098225b1 Mon Sep 17 00:00:00 2001
From: Marcus Eibrink-Lunzenauer <lunzenauer@elan-ev.de>
Date: Tue, 14 Nov 2023 12:47:20 +0100
Subject: [PATCH] Enable updating the start-date of task-groups.
---
.../Routes/Courseware/TaskGroupsUpdate.php | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/lib/classes/JsonApi/Routes/Courseware/TaskGroupsUpdate.php b/lib/classes/JsonApi/Routes/Courseware/TaskGroupsUpdate.php
index 132888e22e4..8662b71ea80 100644
--- a/lib/classes/JsonApi/Routes/Courseware/TaskGroupsUpdate.php
+++ b/lib/classes/JsonApi/Routes/Courseware/TaskGroupsUpdate.php
@@ -63,19 +63,33 @@ class TaskGroupsUpdate extends JsonApiController
return 'Invalid `type` of document´s `data`.';
}
+ if (!self::arrayHas($json, 'data.attributes.start-date')) {
+ return 'Missing `start-date` attribute.';
+ }
+ $startDate = self::arrayGet($json, 'data.attributes.start-date');
+ if (!self::isValidTimestamp($startDate)) {
+ return '`start-date` is not an ISO 8601 timestamp.';
+ }
+
if (!self::arrayHas($json, 'data.attributes.end-date')) {
- return 'Missing `review-start` attribute.';
+ return 'Missing `end-date` attribute.';
}
$endDate = self::arrayGet($json, 'data.attributes.end-date');
if (!self::isValidTimestamp($endDate)) {
return '`end-date` is not an ISO 8601 timestamp.';
}
+
+ if (self::fromISO8601($startDate) > self::fromISO8601($endDate)) {
+ return '`start-date` is later than `end-date`';
+ }
}
private function update(TaskGroup $taskGroup, array $json): TaskGroup
{
+ $startDate = self::fromISO8601(self::arrayGet($json, 'data.attributes.start-date'));
$endDate = self::fromISO8601(self::arrayGet($json, 'data.attributes.end-date'));
+ $taskGroup->start_date = $startDate->getTimestamp();
$taskGroup->end_date = $endDate->getTimestamp();
$taskGroup->store();
--
GitLab