From b192f35c0716210db45892b8ba9ec50bda8ccf47 Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+studip@gmail.com>
Date: Wed, 16 Aug 2023 11:03:20 +0000
Subject: [PATCH] replace .toLocaleString() with $gettext(), fixes #3027

Closes #3027

Merge request studip/studip!2037
---
 resources/assets/javascripts/bootstrap/forms.js | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/resources/assets/javascripts/bootstrap/forms.js b/resources/assets/javascripts/bootstrap/forms.js
index 1a6bc53e152..cffc17d9d63 100644
--- a/resources/assets/javascripts/bootstrap/forms.js
+++ b/resources/assets/javascripts/bootstrap/forms.js
@@ -1,4 +1,4 @@
-import { $gettext } from '../lib/gettext.js';
+import { $gettext, $gettextInterpolate } from '../lib/gettext.js';
 
 // Allow fieldsets to collapse
 $(document).on(
@@ -313,18 +313,21 @@ STUDIP.ready(function () {
                             $(this.$el).find('input, select, textarea').each(function () {
                                 if (!this.validity.valid) {
                                     let note = {
-                                        'name': $(this.labels[0]).find('.textlabel').text(),
-                                        'description': "Fehler!".toLocaleString(),
-                                        'describedby': this.id
+                                        name: $(this.labels[0]).find('.textlabel').text(),
+                                        description: $gettext('Fehler!'),
+                                        describedby: this.id
                                     };
                                     if (this.validity.tooShort) {
-                                        note.description = "Geben Sie mindestens %s Zeichen ein.".toLocaleString().replace("%s", this.minLength);
+                                        note.description = $gettextInterpolate(
+                                            $gettext('Geben Sie mindestens %{min} Zeichen ein.'),
+                                            {min: this.minLength}
+                                        );
                                     }
                                     if (this.validity.valueMissing) {
                                         if (this.type === 'checkbox') {
-                                            note.description = "Dieses Feld muss ausgewählt sein.".toLocaleString();
+                                            note.description = $gettext('Dieses Feld muss ausgewählt sein.');
                                         } else {
-                                            note.description = "Hier muss ein Wert eingetragen werden.".toLocaleString();
+                                            note.description = $gettext('Hier muss ein Wert eingetragen werden.');
                                         }
                                     }
                                     v.STUDIPFORM_VALIDATIONNOTES.push(note);
-- 
GitLab