diff --git a/app/controllers/admin/semester.php b/app/controllers/admin/semester.php index 815a21c1246bd0c3f38eca223e2573a6c07080cd..8ef9f21d09734d3a8f2b6771d50595af41c46c8d 100644 --- a/app/controllers/admin/semester.php +++ b/app/controllers/admin/semester.php @@ -197,11 +197,14 @@ class Admin_SemesterController extends AuthenticatedController // Validation, step 3: Check overlapping with other semesters if (empty($errors)) { - $all_semester = SimpleCollection::createFromArray(Semester::getAll())->findBy('id', $this->semester->id, '<>'); - $collisions = $all_semester->findBy('beginn', [$this->semester->beginn, $this->semester->ende], '>=<='); - $collisions->merge($all_semester->findBy('ende', [$this->semester->beginn, $this->semester->ende], '>=<=')); - if ($collisions->count()) { - $errors[] = sprintf(_('Der angegebene Zeitraum des Semester überschneidet sich mit einem anderen Semester (%s)'), join(', ', $collisions->pluck('name'))); + $collisions_beginn = Semester::findByTimestamp($this->semester->beginn); + if ($collisions_beginn && $collisions_beginn->id !== $this->semester->id) { + $errors[] = sprintf(_('Der Beginn des Semester überschneidet sich mit einem anderen Semester (%s)'), $collisions_beginn->name); + } + + $collisions_ende = Semester::findByTimestamp($this->semester->ende); + if ($collisions_ende && $collisions_ende->id !== $this->semester->id) { + $errors[] = sprintf(_('Das Ende des Semester überschneidet sich mit einem anderen Semester (%s)'), $collisions_ende->name); } }