diff --git a/lib/classes/JsonApi/JsonApiIntegration/QueryChecker.php b/lib/classes/JsonApi/JsonApiIntegration/QueryChecker.php index 045598b510f86ca9048f89be7f39f63ccadf4fab..d1b209a4a3f28dddfbd4e4aa8767d5691bc31e08 100644 --- a/lib/classes/JsonApi/JsonApiIntegration/QueryChecker.php +++ b/lib/classes/JsonApi/JsonApiIntegration/QueryChecker.php @@ -104,16 +104,15 @@ class QueryChecker protected function checkSorting(ErrorCollection $errors, QueryParserInterface $queryParser): void { - $sorts = iterator_to_array($queryParser->getSorts()); - if (null !== $sorts && null !== $this->sortParameters) { - foreach (array_keys($sorts) as $sortParameter) { - if (!array_key_exists($sortParameter, $this->sortParameters)) { - $errors->addQueryParameterError( - QueryParser::PARAM_SORT, - sprintf('Sort parameter %s is not allowed.', $sortParameter) - ); - } - } + $withinAllowed = $this->keysWithinAllowed( + iterator_to_array($queryParser->getSorts()), + $this->sortParameters + ); + if (!$withinAllowed) { + $errors->addQueryParameterError( + QueryParser::PARAM_SORT, + 'Sort parameter should contain only allowed values.' + ); } }