diff --git a/app/views/admin/autoinsert/_search.php b/app/views/admin/autoinsert/_search.php index 3aec17b6f4d2fc731c04f1935d8b9d70ba7d0632..f425a21c24af065b1134574ea34a89a8d67d15fd 100644 --- a/app/views/admin/autoinsert/_search.php +++ b/app/views/admin/autoinsert/_search.php @@ -11,11 +11,8 @@ <label> <?= _('Semester') ?> <?= Semester::getSemesterSelector( - ['name' => 'sem_select', 'id' => 'sem_select', 'class' => 'user_form'], - $sem_select, 'semester_id', - true, - false - )?> + ['name' => 'sem_select', 'id' => 'sem_select', 'class' => 'user_form'] + ) ?> </label> <label> <?= _('Veranstaltung') ?> diff --git a/lib/classes/JsonApi/Routes/Courses/CoursesIndex.php b/lib/classes/JsonApi/Routes/Courses/CoursesIndex.php index 77870f9848cbe02ba73f980b3f9823e037a0b35f..d97cdc0b3c3a4314592126d800a6ba4d783b7b64 100644 --- a/lib/classes/JsonApi/Routes/Courses/CoursesIndex.php +++ b/lib/classes/JsonApi/Routes/Courses/CoursesIndex.php @@ -79,10 +79,6 @@ class CoursesIndex extends JsonApiController if (!$semester) { return 'Invalid "semester".'; } - $semNumber = \Semester::getIndexById($semester->id, true, true); - if ($semNumber === false) { - return 'Invalid "semester".'; - } } } @@ -100,10 +96,6 @@ class CoursesIndex extends JsonApiController $filtering = $this->getQueryParameters()->getFilteringParameters() ?: []; - if (isset($filtering['semester'])) { - $filtering['semester'] = \Semester::getIndexById($filtering['semester'], true, true); - } - return array_merge($defaults, $filtering); } diff --git a/lib/models/Semester.php b/lib/models/Semester.php index afd7b08051bcd2e0bb2a6e75a5f66b0bbed46b51..371ea24b795a5860ddd23a554fbd2496937bf5d5 100644 --- a/lib/models/Semester.php +++ b/lib/models/Semester.php @@ -259,15 +259,13 @@ class Semester extends SimpleORMap * @param integer $default * @param string $option_value * @param boolean $include_all - * @param boolean $use_semester_id * @return string */ public static function getSemesterSelector( $select_attributes = null, $default = 0, $option_value = 'semester_id', - $include_all = true, - $use_semester_id = true + $include_all = true ) { $select_attributes = array_merge([ @@ -291,7 +289,6 @@ class Semester extends SimpleORMap $template->select_attributes = $select_attributes; $template->default = $default; $template->option_value = $option_value; - $template->use_semester_id = $use_semester_id; return $template->render(); } diff --git a/templates/shared/semester-selector.php b/templates/shared/semester-selector.php index 1e559f5f039659386a30036b3d4a2aba5566e9d1..1a405fbe35962122907efc449c0d74623ccd2847 100644 --- a/templates/shared/semester-selector.php +++ b/templates/shared/semester-selector.php @@ -5,7 +5,7 @@ <select <?= $attributes ?>> <? foreach ($semesters as $sem_key => $one_sem) : ?> <? $one_sem['key'] = $sem_key; ?> - <option value="<?= $use_semester_id ? $one_sem[$option_value] : $sem_key ?>" <?= ($one_sem[$option_value] == $default ? "selected" : "") ?>> + <option value="<?= $one_sem[$option_value] ?>" <?= ($one_sem[$option_value] == $default ? "selected" : "") ?>> <?= htmlReady($one_sem['name']) ?> </option> <? endforeach ?>