From 7e791fa1450ef9cafc8d9b79b23f8d298e1569ec Mon Sep 17 00:00:00 2001
From: Ron Lucke <lucke@elan-ev.de>
Date: Fri, 23 Aug 2024 07:48:47 +0000
Subject: [PATCH] PHP 8: Warnungen in JSON-API Route der Courseware
Closes #4268
Merge request studip/studip!3309
---
.../Routes/Courseware/UserProgressesOfUnitsShow.php | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/lib/classes/JsonApi/Routes/Courseware/UserProgressesOfUnitsShow.php b/lib/classes/JsonApi/Routes/Courseware/UserProgressesOfUnitsShow.php
index 7b900e7588f..56cd5cddc16 100644
--- a/lib/classes/JsonApi/Routes/Courseware/UserProgressesOfUnitsShow.php
+++ b/lib/classes/JsonApi/Routes/Courseware/UserProgressesOfUnitsShow.php
@@ -115,9 +115,11 @@ class UserProgressesOfUnitsShow extends NonJsonApiController
$usersCounter = count($courseMemberIds);
foreach ($blks as $blk) {
- $progresses = $userProgresses[$blk];
- $usersProgress = $progresses['count'] ? (float) $progresses['grade'] : 0;
- $data['progress'] += $usersCounter > 0 ? $usersProgress / $usersCounter : 0;
+ if (isset($userProgresses[$blk])) {
+ $progresses = $userProgresses[$blk];
+ $usersProgress = $progresses['count'] ? (float) $progresses['grade'] : 0;
+ $data['progress'] += $usersCounter > 0 ? $usersProgress / $usersCounter : 0;
+ }
}
return $data;
--
GitLab