From 69f9e311a87bd38e4a06ba82358fca165955e61b Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+studip@gmail.com>
Date: Tue, 14 Feb 2023 11:36:05 +0000
Subject: [PATCH] add alt attributes, fixes #821
Closes #821
Merge request studip/studip!1394
---
resources/assets/stylesheets/scss/globalsearch.scss | 11 ++---------
templates/globalsearch/searchbar.php | 11 ++++++-----
2 files changed, 8 insertions(+), 14 deletions(-)
diff --git a/resources/assets/stylesheets/scss/globalsearch.scss b/resources/assets/stylesheets/scss/globalsearch.scss
index d4057b6c644..29066014231 100644
--- a/resources/assets/stylesheets/scss/globalsearch.scss
+++ b/resources/assets/stylesheets/scss/globalsearch.scss
@@ -20,12 +20,9 @@
@include square(16px);
margin-left: -22px;
vertical-align: middle;
-
- opacity: 0;
- transition: opacity $transition-duration;
}
- &.has-value #globalsearch-clear {
- opacity: 1;
+ &:not(.has-value) #globalsearch-clear {
+ display: none;
}
// The actual search input
@@ -284,10 +281,6 @@ html.responsive-display {
top: calc($bar-bottom-container-height + $padding);
width: calc(100vw - (2 * $padding));
}
-
- #globalsearch-clear {
- opacity: 1;
- }
}
}
html:not(.size-large) {
diff --git a/templates/globalsearch/searchbar.php b/templates/globalsearch/searchbar.php
index beb4ba22baa..93a8ab51224 100644
--- a/templates/globalsearch/searchbar.php
+++ b/templates/globalsearch/searchbar.php
@@ -1,13 +1,14 @@
<div id="globalsearch-searchbar" role="search" aria-label="<?= _('Globale Suche') ?>">
<input class="hidden-small-down" type="text" name="globalsearchterm" id="globalsearch-input"
placeholder="<?= _('Was suchen Sie?') ?>" role="searchbox">
- <?= Icon::create('decline', Icon::ROLE_INACTIVE)->asImg([
- 'id' => 'globalsearch-clear',
- 'class' => 'hidden-small-down'
+ <?= Icon::create('decline', Icon::ROLE_INACTIVE)->asInput([
+ 'id' => 'globalsearch-clear',
+ 'class' => 'hidden-small-down',
+ 'alt' => _('Suche zurücksetzen'),
]) ?>
<?= Icon::create('search', Icon::ROLE_INFO_ALT)->asInput([
- 'id' => 'globalsearch-icon',
- 'aria-label' => _('Suche starten')
+ 'id' => 'globalsearch-icon',
+ 'alt' => _('Suche starten')
]) ?>
<div id="globalsearch-list">
<a href="#" id="globalsearch-togglehints" data-toggle-text="<?= _('Tipps ausblenden') ?>">
--
GitLab