From 5f0d9a73cab0a05336a23cee719f7809b8d8f067 Mon Sep 17 00:00:00 2001
From: Moritz Strohm <strohm@data-quest.de>
Date: Mon, 27 May 2024 18:29:43 +0200
Subject: [PATCH] added aria-label text for icons on the profile page
---
app/views/news/_actions.php | 9 ++++++---
app/views/news/display.php | 11 +++++++----
app/views/questionnaire/_widget_questionnaire.php | 2 +-
app/views/questionnaire/widget.php | 9 ++++++---
4 files changed, 20 insertions(+), 11 deletions(-)
diff --git a/app/views/news/_actions.php b/app/views/news/_actions.php
index 343cd102857..d67de26a80b 100644
--- a/app/views/news/_actions.php
+++ b/app/views/news/_actions.php
@@ -37,16 +37,19 @@ if ($new['allow_comments']) :
<? if ($new->havePermission('edit')): ?>
- <a href="<?= URLHelper::getLink('dispatch.php/news/edit_news/' . $new->id) ?>" data-dialog>
+ <a href="<?= URLHelper::getLink('dispatch.php/news/edit_news/' . $new->id) ?>" data-dialog
+ title="<?= _('Bearbeiten') ?>" aria-label="<?= _('Bearbeiten') ?>">
<?= Icon::create('edit') ?>
</a>
<? if ($new->havePermission('unassign', $range)): ?>
- <a href=" <?= URLHelper::getLink('', ['remove_news' => $new->id, 'news_range' => $range]) ?>" >
+ <a href=" <?= URLHelper::getLink('', ['remove_news' => $new->id, 'news_range' => $range]) ?>"
+ title="<?= _('Nicht mehr abonnieren') ?>" aria-label="<?= _('Nicht mehr abonnieren') ?>">
<?= Icon::create('remove') ?>
</a>
<? endif; ?>
<? if ($new->havePermission('delete')): ?>
- <a href=" <?= URLHelper::getLink('', ['delete_news' => $new->id]) ?>" >
+ <a href=" <?= URLHelper::getLink('', ['delete_news' => $new->id]) ?>"
+ title="<?= _('Löschen') ?>" aria-label="<?= _('Löschen') ?>">
<?= Icon::create('trash') ?>
</a>
<? endif; ?>
diff --git a/app/views/news/display.php b/app/views/news/display.php
index 7d9e2d0334e..5f62443f434 100644
--- a/app/views/news/display.php
+++ b/app/views/news/display.php
@@ -9,18 +9,21 @@
<nav>
<? if ($perm): ?>
<a href="<?= $controller->link_for('news/edit_news/new/' . $range); ?>" data-dialog
- title="<?= _('Hinzufügen') ?>">
+ title="<?= _('Hinzufügen') ?>" aria-label="<?= _('Hinzufügen') ?>">
<?= Icon::create('add') ?>
</a>
<? endif; ?>
<? if ($perm && Config::get()->NEWS_RSS_EXPORT_ENABLE): ?>
- <a data-dialog="size=auto;reload-on-close" title="<?=_('RSS-Feed konfigurieren') ?>" href="<?= $controller->link_for('news/rss_config/' . $range); ?>">
+ <a data-dialog="size=auto;reload-on-close" title="<?=_('RSS-Feed konfigurieren') ?>"
+ aria-label="<?=_('RSS-Feed konfigurieren') ?>"
+ href="<?= $controller->link_for('news/rss_config/' . $range); ?>">
<?= Icon::create('admin') ?>
</a>
<? endif; ?>
<? if ($rss_id): ?>
- <a href="<?= URLHelper::getLink('rss.php', ['id' => $rss_id]) ?>">
- <?= Icon::create('rss')->asImg(['title' => _('RSS-Feed')]) ?>
+ <a href="<?= URLHelper::getLink('rss.php', ['id' => $rss_id]) ?>"
+ title="<?= _('RSS-Feed') ?>" aria-label="<?= _('RSS-Feed') ?>">
+ <?= Icon::create('rss') ?>
</a>
<? endif; ?>
</nav>
diff --git a/app/views/questionnaire/_widget_questionnaire.php b/app/views/questionnaire/_widget_questionnaire.php
index 22ecf7252cf..b22c38376d2 100644
--- a/app/views/questionnaire/_widget_questionnaire.php
+++ b/app/views/questionnaire/_widget_questionnaire.php
@@ -30,7 +30,7 @@
<span title="<?= _("Anzahl der Antworten") ?>">
<?= $questionnaire->countAnswers() ?>
</span>
- <span title="<?= _("QR-Code zu diesem Fragebogen anzeigen") ?>">
+ <span title="<?= _("QR-Code zu diesem Fragebogen anzeigen") ?>" aria-label="<?= _("QR-Code zu diesem Fragebogen anzeigen") ?>">
<? $oldbase = URLHelper::setBaseURL($GLOBALS['ABSOLUTE_URI_STUDIP']) ?>
<a href="<?=
URLHelper::getLink(
diff --git a/app/views/questionnaire/widget.php b/app/views/questionnaire/widget.php
index 9804b24646b..6d7f4b3effe 100644
--- a/app/views/questionnaire/widget.php
+++ b/app/views/questionnaire/widget.php
@@ -8,15 +8,18 @@
<nav>
<? if ($allowed_to_add) : ?>
<? if ($statusgruppen_ids): ?>
- <a href="<?= $controller->link_for('questionnaire/add_to_context') ?>" data-dialog="size=auto" title="<?= _('Fragebogen hinzufügen') ?>">
+ <a href="<?= $controller->link_for('questionnaire/add_to_context') ?>" data-dialog="size=auto"
+ title="<?= _('Fragebogen hinzufügen') ?>" aria-label="<?= _('Fragebogen hinzufügen') ?>">
<?= Icon::create("add", "clickable")->asimg("16px", ['class' => "text-bottom"]) ?>
</a>
<? else: ?>
- <a href="<?= $controller->link_for('questionnaire/edit', compact('range_type', 'range_id')) ?>" data-dialog title="<?= _('Fragebogen hinzufügen') ?>">
+ <a href="<?= $controller->link_for('questionnaire/edit', compact('range_type', 'range_id')) ?>" data-dialog
+ title="<?= _('Fragebogen hinzufügen') ?>" aria-label="<?= _('Fragebogen hinzufügen') ?>">
<?= Icon::create("add", "clickable")->asimg("16px", ['class' => "text-bottom"]) ?>
</a>
<? endif ?>
- <a href="<?= URLHelper::getLink("dispatch.php/questionnaire/" . ($range_type == 'course' || $range_type == 'institute' ? 'course' : ''). "overview") ?>" title="<?= _('Fragebögen verwalten') ?>">
+ <a href="<?= URLHelper::getLink("dispatch.php/questionnaire/" . ($range_type == 'course' || $range_type == 'institute' ? 'course' : ''). "overview") ?>"
+ title="<?= _('Fragebögen verwalten') ?>" aria-label="<?= _('Fragebögen verwalten') ?>">
<?= Icon::create("admin", "clickable")->asimg("16px", ['class' => "text-bottom"]) ?>
</a>
<? endif ?>
--
GitLab