From 5af0698e302dfe412106dded077a0e14607a374f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Noack?= <noack@data-quest.de>
Date: Mon, 6 Jan 2025 13:54:00 +0000
Subject: [PATCH] repair Shibboleth login fixes #5045
Closes #5045
Merge request studip/studip!3810
---
lib/authentication/Manager.php | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/authentication/Manager.php b/lib/authentication/Manager.php
index d9c9f95927f..b25efadf9d0 100644
--- a/lib/authentication/Manager.php
+++ b/lib/authentication/Manager.php
@@ -55,7 +55,7 @@ class Manager
Metrics::increment('core.sso_login.attempted');
// then do login
$authplugin = StudipAuthAbstract::GetInstance($provider);
- if ($authplugin) {
+ if ($authplugin instanceof \StudipAuthSSO) {
$authplugin->authenticateUser('', '');
if ($authplugin->getUser()) {
$user = $authplugin->getStudipUser($authplugin->getUser());
@@ -71,8 +71,8 @@ class Manager
}
Metrics::increment('core.sso_login.succeeded');
- sess()->regenerateId(['auth', '_language', 'phpCAS', 'contrast']);
$this->setAuthenticatedUser($user);
+ sess()->regenerateId(['auth', '_language', 'phpCAS', 'contrast']);
}
}
}
--
GitLab