From 35ed31ce8e6f281a027df955b3251f5002875420 Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+studip@gmail.com>
Date: Tue, 25 Apr 2023 09:02:19 +0000
Subject: [PATCH] align sorting display and remove obsolete icons, fixes #2580

Closes #2580

Merge request studip/studip!1737
---
 public/assets/images/dreieck_down.png         | Bin 1272 -> 0 bytes
 public/assets/images/dreieck_down@2x.png      | Bin 1362 -> 0 bytes
 public/assets/images/dreieck_up.png           | Bin 1283 -> 0 bytes
 public/assets/images/dreieck_up@2x.png        | Bin 1344 -> 0 bytes
 resources/assets/stylesheets/less/tables.less |  25 ++++++++++--------
 5 files changed, 14 insertions(+), 11 deletions(-)
 delete mode 100644 public/assets/images/dreieck_down.png
 delete mode 100644 public/assets/images/dreieck_down@2x.png
 delete mode 100644 public/assets/images/dreieck_up.png
 delete mode 100644 public/assets/images/dreieck_up@2x.png

diff --git a/public/assets/images/dreieck_down.png b/public/assets/images/dreieck_down.png
deleted file mode 100644
index 1b3eb528cede821e2d8a9b6d638aa75a32a3583a..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 1272
zcmeAS@N?(olHy`uVBq!ia0vp^0wB!61|;P_|4#%`k|nMYCBgY=CFO}lsSJ)O`AMk?
zp1FzXsX?iUDV2pMQ*9U+m{l@EB1$5BeXNr6bM+EIYV;~{3xK*A7;Nk-3KEmEQ%e+*
zQqwc@Y?a>c-mj#PnPRIHZt82`Ti~3Uk?B!Ylp0*+7m{3+ootz+WN)WnQ(*-(AUCxn
zQK2F?C$HG5!d3}vt`(3C64qBz04piUwpD^SD#ABF!8yMuRl!uxSU1_g&``n5OwZ87
z)XdCKN5ROz&`93^h|F{iO{`4Ktc=VRpg;*|TTx1yRgjAt)Gi>;Rw<*Tq`*pFzr4I$
zuiRKKzbIYb(9+TpWQLKEE>MMTab;dfVufyAu`<jAm(=3qqRfJl%=|nBkco*&`K2Yc
zN<f!FypUS}H#V;r8ce_d)2~P@&^OdG0C@?f(AO8g(%f9Q>f(~1RD^r68eAMwS&*t9
zlv<o$T9gcoxHM&uRRvbgMX8A;`9&f5`8lvq49LhY$uG{xFHmp}HdD~>O-#<r0|{t?
zb@=*PdFB<DB<3Zjdb-#u0nO0M%uKOzF*J8FGIBOCFfns9G;}p~baJ(Db+vGFvT!qW
zak6lR>2=9ZF3nBND}m`v0qS+LurzjZax=iG7nB%s3xGDeq!wkCrKY$Q<>xAZJ#CeV
z+bu>o&4cPq!QvLEKa6qe)dxC89~8AnQ4JFUrXLU!o^XL2c+yYJ1E%*PV8Z^Qxi5}^
zficU|#WAGfR??sU|LvJo8#)`E4m6$FS@C$~f$RD9zB6Xd{P*Cpvbtu)wAtN%ZRPpd
zS22d?*(aY}6T7ix_GDj~e#Z4Rb4z%IoOC4D@Q4QPeUP&7UsR~$mbsmsosHd--^yF1
zB_*X?2$+^(UHtUo=llEr8zr_dUPx<;sQ-Lasp$^?|9^kmmDnGh_Tab|8ZH$7=i6U#
zH^anv|0UQO{ycfT=C@zWl=4IU@edLbTD%OKemF73{H?Kh^S<oN`NRt$(|+`uiv9cZ
z_w)ia{cSF8P7fF_gt@JF+vD(0S2c3t(skEn6`YOW4G0%W-(VhIt*mv#_~rTe^$E8f
zO(xubov`lP!K+ct1y&a>Pe^+3{AmosmjkgI%q1k(G5qv)eB`34GC{k+@YB6>A*rvn
zzuzyhrgv%;xA5G3O-DNYI^Aw<;<1T&bGqSQJm;6+QHhLsmnIo$Ya27Ov%g-g$@}o+
rfhj*-UE@SnTODIO?;|43AdtYo-CCM^_K!mhs4Vhy^>bP0l+XkKp#;m6

diff --git a/public/assets/images/dreieck_down@2x.png b/public/assets/images/dreieck_down@2x.png
deleted file mode 100644
index c11d6889e2f69cb599d6010e3608d94c4249b501..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 1362
zcmeAS@N?(olHy`uVBq!ia0vp^3LwnE1|*BCs=fdz$r9IylHmNblJdl&R0hYC{G?O`
z&)mfH)S%SFl*+=BsWuD@%qp275hW46K32*3xq68pHF_1f1wh>l3^w)^1&PVosU-?Y
zsp*+{wo31J?^jaDOtDo8H}y5}EpSfF$n>ZxN)4{^3rViZPPR-@vbR&PsjvbXkegbP
zs8ErclUHn2VXFi-*9yo63F|8<fR&VF+bTgE72zA8;GAESs$i;Tteb3LXsBRjre|nk
zYG!7rqhMrUXryldL}t2%CRV0qRz~IuP@n{~ttchUD#*nRY8Q}atCUevQedU8UtV6W
zS8lAAUzDzIXlZE)GQ-G77pOwFxH7LKu|hYmSQ%!5OKNd)QD#9&W`3Rm$i&2?{L&Iz
zC7??oUdSzg8=F@Q4JKfK=~pBc=o{)8fV>1#=<ADLX>KlDb#X~hD#E>34K5C;EJ)Q4
zN-fSWElLJPT$(b-ssbzLqSVBa{GyQj{2W*)24v)y<QHe;7brLfn<;4cCMIX*fdn+c
zI(&VtJoAc667!N%JzZ>-fM)1rW~NxVSy&o7Ik_1dn3y>l8oC-gI=Nc7x>~q7S-2Ux
zI9WKu^t$9Hm*%GCmB93-AoQBx)C)=sxdlL*T~doO%TiO^it=+6z@E0s#O)SCoaRCG
zrr>sq5l+4OK*#8Vq82HtVM4(417gAxE|3FH`l)%q^j-u^*e|#@g)uNN9`ST>45_&F
zX4-yz7Dtie`PXHmY`M7Vnb!X1{=+FHx>Q5tiAAs1VkM<0)>h%x43WBP9&?^~ga|pR
z-0A;V`O$1=PT%aCw@;f|pES=;Pk;8eF8`SEu_acPe?r>b7dadk_4vQlU{358h3yF{
zY?l7~>N^=LzB%k)V{^bwv)@u-%QdEyGj6;G4R_=pEc*CJ*5XLj{Yb_=A2?6CpAq$+
z*nZyH<nfw@X9w+e^et$aW6R9?qr{!7@kwLWe%^gkSFZhFbmPgN)#p^@SDj1Mh-)}$
zH9x<P%cdx=`?I8IOk&(dy~6>fCuT5J^C`{<%aY<O%W|2;E&kxnqn<VMo3zjV$<moC
zpgm7<x39#nTjpjr{tJCdcpPyv?s&vxv2dquqqW&aiL81z&9yeRPkX$Fo2hZ9+V7^X
zt3tQ!vhgrkw)X)W&#K*rH=gg>6cL|&JU3&D^|^L0qZPkJ&sJowwz;l8vuYu~OoJhB
z?;mR>;YA&5zXslCb~CPV-<>?+=jx)XyEy(oZDWryG}(7y=@u3qjTd*ypNf8U6*-dY
z_Oj?j{i<Bcfa{X1e-nh(H1el^zkP@G|5JV@?+dD#L44w&ujM@EJ?&)bWGd{FXJlh|
XI8ns5ujVKZsFd?`^>bP0l+XkKT2krC

diff --git a/public/assets/images/dreieck_up.png b/public/assets/images/dreieck_up.png
deleted file mode 100644
index eefd3e09c79bb421e40367dc235317f1c93cbfe7..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 1283
zcmeAS@N?(olHy`uVBq!ia0vp^0wB!61|;P_|4#%`k|nMYCBgY=CFO}lsSJ)O`AMk?
zp1FzXsX?iUDV2pMQ*9U+m{l@EB1$5BeXNr6bM+EIYV;~{3xK*A7;Nk-3KEmEQ%e+*
zQqwc@Y?a>c-mj#PnPRIHZt82`Ti~3Uk?B!Ylp0*+7m{3+ootz+WN)WnQ(*-(AUCxn
zQK2F?C$HG5!d3}vt`(3C64qBz04piUwpD^SD#ABF!8yMuRl!uxSU1_g&``n5OwZ87
z)XdCKN5ROz&`93^h|F{iO{`4Ktc=VRpg;*|TTx1yRgjAt)Gi>;Rw<*Tq`*pFzr4I$
zuiRKKzbIYb(9+TpWQLKEE>MMTab;dfVufyAu`<jAm(=3qqRfJl%=|nBkco*&`K2Yc
zN<f!FypUS}H#V;r8ce_d)2~P@&^OdG0C@?f(AO8g(%f9Q>f(~1RD^r68eAMwS&*t9
zlv<o$T9gcoxHM&uRRvbgMX8A;`9&f5`8lvq49LhY$uG{xFHmp}HdD~>O-#<r0|{t?
zb@=*PdFB<DB<3Zjdb-#u0nO0M%uKOzF*J8FGIDY@Ffns9G;}p~baJ(Db+vGFvT!qW
zak6lR>2=9ZF3nBND}m`vLFjeCsTY(OatnYqyQCInmZhe+73JqDfIV%MiQ6rXIL(9V
zO~LIJC!BiqfsWA!MJ-ZP!-Rn82gHOYTp$OY^i%VI>AeV;u)i+jKgqzrSnBEG7*cU7
z>CgZF_ROjcosCWnmm9v%-)9)J^Y5I8*Wd5w5zn_dn#sVe*O^@&XAtr=CnY&OxlmaA
z;a#(xdVl6K$g6+U`|<TRfAiv{vu^&(_7_`qqC0bM)$f@V`ZYhlO-}sXxSD76wt1%?
zC!`BT?fjba@SO7X1CLxJ3mzR}ZsWc_Kcep6FXM)}y;B)I+}GW&4CGhwyU@Ttf1mN4
zegC^Ur%v7Z<o^EpH3u@-g8o}rT1K93cqFmz0LPK%>+OwlZWLdXk?7bb^JYzgp+N1+
zW1A=3-~ZpQ;`hhbGiT}W-_iT=<0reava+-0i86)n@*xsWxXSeWwoO`pzs@Mld`-%q
zKVR9GF`kdFPkJ$X`*oR&+5Bh9Bp5!PkE@g^_<Ya%b8ofY-~9!DHHF*6@74V{RrBM^
z++F(}Ztt)C-=BC8Xw!}L_v+%-FVlF&{^Z|5g9lGqe_wj`i%aKD%p3N9#tF{^-4y<O
v{;u!cuzKH`4u$Ww8*V%}>vM#ufq|K!=f)<p`e%!^LB*1%tDnm{r-UW|+yLQJ

diff --git a/public/assets/images/dreieck_up@2x.png b/public/assets/images/dreieck_up@2x.png
deleted file mode 100644
index 165dc6c1a52a288d784f1765849f298fab2133ac..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 1344
zcmeAS@N?(olHy`uVBq!ia0vp^3LwnE1|*BCs=fdz$r9IylHmNblJdl&R0hYC{G?O`
z&)mfH)S%SFl*+=BsWuD@%qp275hW46K32*3xq68pHF_1f1wh>l3^w)^1&PVosU-?Y
zsp*+{wo31J?^jaDOtDo8H}y5}EpSfF$n>ZxN)4{^3rViZPPR-@vbR&PsjvbXkegbP
zs8ErclUHn2VXFi-*9yo63F|8<fR&VF+bTgE72zA8;GAESs$i;Tteb3LXsBRjre|nk
zYG!7rqhMrUXryldL}t2%CRV0qRz~IuP@n{~ttchUD#*nRY8Q}atCUevQedU8UtV6W
zS8lAAUzDzIXlZE)GQ-G77pOwFxH7LKu|hYmSQ%!5OKNd)QD#9&W`3Rm$i&2?{L&Iz
zC7??oUdSzg8=F@Q4JKfK=~pBc=o{)8fV>1#=<ADLX>KlDb#X~hD#E>34K5C;EJ)Q4
zN-fSWElLJPT$(b-ssbzLqSVBa{GyQj{2W*)24v)y<QHe;7brLfn<;4cCMIX*fdn+c
zI(&VtJoAc667!N%JzZ>-fM)1rW~NxV7@9j7895smn3y>l8oC-gI=Nc7x>~q7S-2Ux
zI9WKu^t$9Hm*%GCmB93-AoLpI)C)=sxdlL*T~doO%TiO^it=+6z@E0s#OW3%SDfZS
z^`_u-i<28pz4}1M=!2pbDXL*Y!1M!R!V@l#15f&?dBF5u1Wee6X8LO~FfeZNba4!+
zxb<e5t@q&ok+#WO>J;?y{6Yg9=g6#)Z&nBuDOqX3-PbjH_mp)?j}}aR;9pQwu&TLv
z@$3f=@(ThTqow9Es|z@J=NCD5P2lElU-EMA^F8lR?k%jnU;fL|X8Cz#{|EJI2B9l=
z2Jpm+FPxCFZjtM!Trpii{s%&Ko3|XO&A)Q{Nac#db7H!UW~wgu==C`B$-bX1h2}~t
zCuP+>n&@TEVRX{!yZmMkhY;!J>WFD^0jlx~xO}&&*K%*Enpva0Wrwf^Lv~@c;xwkH
zzXp4pJjMCMKeLE>o(W;qKljM$rJRq8Sb0cq=#3E3JzI1+=B@o&q4#6&geaz0wcQnm
zo~E4m?YH<$@o$^^CV>Z6uy0v;?4jPJn!8<-;%>C^Z}f_b)@ChfQf)qZcyGY9d72TC
z0#!@%lHM6!Z#-2MvC~XUMp!Rlf%EtB+pD4rI=Hs~srQ&FXdQKoGvnIg3k|HyKNr8U
zJ8V|N{+xyLk3{r>d*Q-5a&P*yHypOv-+7NoL_%@Tfh|W@{$%U^pelAOs9__cv6#GW
z(A_mRF63r^tNKyDEVM%GgoXcGi*x(CKC^scxg=N5#KZ6{WYx|k@f}w|Wtyj}pUXO@
GgeCw7W8w4w

diff --git a/resources/assets/stylesheets/less/tables.less b/resources/assets/stylesheets/less/tables.less
index 3018062f1b2..6eab679e5cc 100644
--- a/resources/assets/stylesheets/less/tables.less
+++ b/resources/assets/stylesheets/less/tables.less
@@ -649,14 +649,15 @@ table.withdetails {
         display: inline-block;
         height: 16px;
         margin-left: 0;
-        .retina-background-image('dreieck_@{direction}.png', 'dreieck_@{direction}@2x.png', 16px, 16px);
-        vertical-align: text-top;
+        .background-icon('arr_1@{direction}');
+        vertical-align: text-bottom;
         width: 16px;
     }
 }
 
 .sortable-table {
-    .header, .tablesorter-header:not(.sorter-false) {
+    .header,
+    .tablesorter-header:not(.sorter-false) {
         white-space: nowrap;
 
         color: @base-color;
@@ -664,18 +665,20 @@ table.withdetails {
             color: @active-color;
             cursor: pointer;
         }
+        &.tablesorter-headerDesc:hover .tablesorter-header-inner::after {
+            .background-icon('arr_1down', 'status-red');
+        }
+        &.tablesorter-headerAsc:hover .tablesorter-header-inner::after {
+            .background-icon('arr_1up', 'status-red');
+        }
     }
-    .headerSortUp, .tablesorter-headerDesc .tablesorter-header-inner {
+    .headerSortUp,
+    .tablesorter-headerDesc .tablesorter-header-inner {
         .sortable-dreieck('down');
-        &::after {
-            vertical-align: inherit;
-        }
     }
-    .headerSortDown, .tablesorter-headerAsc .tablesorter-header-inner {
+    .headerSortDown,
+    .tablesorter-headerAsc .tablesorter-header-inner {
         .sortable-dreieck('up');
-        &::after {
-            vertical-align: inherit;
-        }
     }
     .tablesorter-headerUnSorted:not(.sorter-false) .tablesorter-header-inner {
         margin-right: 15px;
-- 
GitLab