From 33b91e8d791b8f3530e4c0cb609fcfbfcf507d14 Mon Sep 17 00:00:00 2001
From: David Siegfried <david.siegfried@uni-vechta.de>
Date: Fri, 5 Apr 2024 09:30:28 +0000
Subject: [PATCH] fix typo and and always selects a semester, fixes #3954
Closes #3954
Merge request studip/studip!2812
---
app/controllers/calendar/calendar.php | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/app/controllers/calendar/calendar.php b/app/controllers/calendar/calendar.php
index c605c01c459..85b5b433dc2 100644
--- a/app/controllers/calendar/calendar.php
+++ b/app/controllers/calendar/calendar.php
@@ -660,7 +660,7 @@ class Calendar_CalendarController extends AuthenticatedController
public function add_courses_action()
{
$selected_semester_pseudo_id = Request::option('semester_id');
- $this->selected_semesters_id = '';
+ $this->selected_semester_id = '';
$this->available_semester_data = [];
$semesters = Semester::getAll();
foreach ($semesters as $semester) {
@@ -691,8 +691,9 @@ class Calendar_CalendarController extends AuthenticatedController
$this->selected_semester_id = $semester->id;
} else {
$this->selected_semester_id = $selected_semester_pseudo_id ?? '';
- if (!Semester::exists($this->selected_semesters_id)) {
- $this->selected_semester_id = '';
+ if (!Semester::exists($this->selected_semester_id)) {
+ $semester = Semester::findCurrent();
+ $this->selected_semester_id = $semester->id;
}
}
--
GitLab