From 2f063e32f03db806980c9a3ccab52fe637c070bf Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+studip@gmail.com>
Date: Wed, 8 Mar 2023 13:40:27 +0000
Subject: [PATCH] ensure user is valid, fixes #2288
Closes #2288
Merge request studip/studip!1512
---
lib/classes/ForumAbo.php | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/classes/ForumAbo.php b/lib/classes/ForumAbo.php
index 551164ffa71..c32761c790f 100644
--- a/lib/classes/ForumAbo.php
+++ b/lib/classes/ForumAbo.php
@@ -85,6 +85,7 @@ class ForumAbo
// fetch all users to notify, exclude current user
$stmt = $db->prepare("SELECT DISTINCT user_id
FROM forum_abo_users
+ JOIN auth_user_md5 USING (user_id)
WHERE topic_id IN (:topic_ids)
AND user_id != :user_id");
$stmt->bindValue(':topic_ids', array_keys($path), StudipPDO::PARAM_ARRAY);
@@ -117,10 +118,12 @@ class ForumAbo
if ($user->locked || ($expiration > 0 && $expiration < time())) {
$force_email = false;
}
- $parent_id = ForumEntry::getParentTopicId($topic['topic_id']);
setTempLanguage($data['user_id']);
- $notification = sprintf(_("%s hat einen Beitrag geschrieben"), ($topic['anonymous'] ? _('Anonym') : $topic['author']));
+ $notification = sprintf(
+ _('%s hat einen Beitrag geschrieben'),
+ $topic['anonymous'] ? _('Anonym') : $topic['author']
+ );
restoreLanguage();
PersonalNotifications::add(
--
GitLab