diff --git a/lib/classes/MyRealmModel.php b/lib/classes/MyRealmModel.php index ebc09cb6cae6f4cd655b00ecde681342d4459f42..d905ca9b5f79bc6d1a26c6eb4da2f3fccb2159f3 100644 --- a/lib/classes/MyRealmModel.php +++ b/lib/classes/MyRealmModel.php @@ -163,8 +163,8 @@ class MyRealmModel public static function getCourses($min_sem_key, $max_sem_key, $params = []) { // init - $order_by = $params['order_by']; - $order = $params['order']; + $order_by = $params['order_by'] ?? null; + $order = $params['order'] ?? null; $deputies_enabled = $params['deputies_enabled']; $sem_data = Semester::getAllAsArray(); @@ -179,7 +179,7 @@ class MyRealmModel } $semesters = Semester::findMany($semester_ids); - $studygroup_filter = !$params['studygroups_enabled'] ? false : true; + $studygroup_filter = !empty($params['studygroups_enabled']); $ordering = ''; // create ordering if (!$order_by) { diff --git a/lib/classes/ResponsiveHelper.php b/lib/classes/ResponsiveHelper.php index eea898154584965c590a61cc2f317c2f1eb1e2a9..bb07add4ce68355d6b0f2407771253a514b1c04b 100644 --- a/lib/classes/ResponsiveHelper.php +++ b/lib/classes/ResponsiveHelper.php @@ -195,7 +195,7 @@ class ResponsiveHelper $currentIndex = -1; foreach ($sem_data as $index => $semester) { - if ($semester['current']) { + if (!empty($semester['current'])) { $currentIndex = $index; break; } diff --git a/lib/classes/URLHelper.php b/lib/classes/URLHelper.php index 732ce995dac50d901244c99df7564158d808f155..4421fdf7718dfd1be904e459a40f288a9128f4b5 100644 --- a/lib/classes/URLHelper.php +++ b/lib/classes/URLHelper.php @@ -67,7 +67,7 @@ class URLHelper return $url; } - if ($url[0] === '/') { + if (isset($url[0]) && $url[0] === '/') { preg_match('%^[a-z]+://[\w:.-]+%', $base_url, $host); $base_url = $host[0] ?? ''; } diff --git a/templates/header.php b/templates/header.php index c8aeb1cacd91a558319687d0afe92a5fa107f585..c0181e69998a8edfa5d8c79a641daaf4cd0d43ae 100644 --- a/templates/header.php +++ b/templates/header.php @@ -287,7 +287,7 @@ if ($navigation) { <nav id="navigation-level-2" aria-current="page" aria-label="<?= _('Zweite Navigationsebene') ?>"> <? if (PageLayout::isHeaderEnabled() /*&& isset($navigation)*/) : ?> - <?= $this->render_partial('tabs', compact('navigation', 'membership')) ?> + <?= $this->render_partial('tabs', compact('navigation')) ?> <? endif; ?> </nav> <? endif; ?>