diff --git a/app/controllers/resources/room_request.php b/app/controllers/resources/room_request.php index 6421f23aa9ae6527accd15f2908b911e23a411e6..4c51bebda9665606938c359e5cbc05a618fdfbc3 100644 --- a/app/controllers/resources/room_request.php +++ b/app/controllers/resources/room_request.php @@ -1739,8 +1739,8 @@ class Resources_RoomRequestController extends AuthenticatedController if ($save_only) { // redirect to reload all infos and showing the most current ones $this->redirect('resources/room_request/resolve/' . $request_id); - } elseif (Request::isDialog() && Context::get()) { - $this->response->add_header('X-Dialog-Execute', '{"func": "STUDIP.AdminCourses.App.loadCourse", "payload": "'.Context::get()->id.'"}'); + } elseif (Request::isDialog() && Context::get()->id) { + $this->response->add_header('X-Dialog-Execute', '{"func": "STUDIP.AdminCourses.App.loadCourse", "payload": "' . Context::get()->id . '"}'); } } diff --git a/app/views/course/timesrooms/_roomRequest.php b/app/views/course/timesrooms/_roomRequest.php index 989fccb61205a7f500b3b400ef0887f036fb0860..ffa72b0078c048629237b9120375112f75b6e160 100644 --- a/app/views/course/timesrooms/_roomRequest.php +++ b/app/views/course/timesrooms/_roomRequest.php @@ -93,8 +93,7 @@ ), _('Diese Anfrage selbst auflösen'), Icon::create('admin'), - ['title' => _('Diese Anfrage selbst auflösen')], - ['data-dialog' => '1'] + ['title' => _('Diese Anfrage selbst auflösen'), 'data-dialog' => ''] ) ?> <? endif ?> <? $actionMenu->addLink( diff --git a/resources/assets/javascripts/lib/extract_callback.js b/resources/assets/javascripts/lib/extract_callback.js index bf7ac79b6edaaa2d1f4fd01159b3ec2f8c910e8b..a6302759300c11fd13743a5bf2051b934785ec05 100644 --- a/resources/assets/javascripts/lib/extract_callback.js +++ b/resources/assets/javascripts/lib/extract_callback.js @@ -56,8 +56,9 @@ export default function extractCallback(cmd, payload, root = window) { } } - if (callback[chunk] === undefined) { - throw 'Error: Undefined callback ' + cmd; + if (callback === null || callback[chunk] === undefined) { + console.log('Error: Undefined callback ' + cmd); + return; } if (typeof callback[chunk] === 'function' && parameters !== null) { diff --git a/tests/jest/extract_callback.test.js b/tests/jest/extract_callback.test.js index d67d7e647f400611b162fa2d4aec83d936f97cef..895aa8d610c7ab1f91cff9dee2c5e3902d19e433 100644 --- a/tests/jest/extract_callback.test.js +++ b/tests/jest/extract_callback.test.js @@ -108,14 +108,4 @@ describe('extract_callback()', () => { expect(callback).toHaveBeenCalledWith(['foo', 23]); }) - - test('invalid', () => { - expect(() => { - extractCallback('callback', {}, {}); - }).toThrow(); - - expect(() => { - extractCallback('{}', {}, {}); - }).toThrow(); - }) });