From cac75e5aa8680d33db07b46074dcc0a87df81241 Mon Sep 17 00:00:00 2001
From: Moritz Strohm <strohm@data-quest.de>
Date: Tue, 28 Jun 2022 19:16:17 +0000
Subject: [PATCH] fix for BIESt closes #519
Merge request studip/studip!664
---
templates/sidebar/list-widget.php | 2 +-
templates/sidebar/options-widget-form.php | 2 +-
templates/sidebar/select-widget.php | 3 ++-
templates/sidebar/sidebar.php | 2 +-
4 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/templates/sidebar/list-widget.php b/templates/sidebar/list-widget.php
index b396455166a..0507cfab7ce 100644
--- a/templates/sidebar/list-widget.php
+++ b/templates/sidebar/list-widget.php
@@ -1,4 +1,4 @@
-<ul class="<?= implode(' ', $css_classes) ?>">
+<ul class="<?= implode(' ', $css_classes) ?>" aria-label="<?= htmlReady($title) ?>">
<? foreach ($elements as $index => $element): ?>
<? if ($element instanceof LinkElement): ?>
<? $icon = $element->icon ?? null ?>
diff --git a/templates/sidebar/options-widget-form.php b/templates/sidebar/options-widget-form.php
index 0c6e212388c..5dc91f2f1b6 100644
--- a/templates/sidebar/options-widget-form.php
+++ b/templates/sidebar/options-widget-form.php
@@ -21,7 +21,7 @@
<? elseif ($element['type'] == 'select'): ?>
<label>
<?= htmlReady($element['label']) ?>
- <select name="<?= htmlReady($element['name']) ?>">
+ <select name="<?= htmlReady($element['name']) ?>" aria-label="<?= htmlReady($title) ?>">
<? foreach ($element['options'] as $key => $name): ?>
<option value="<?= htmlReady($key) ?>">
<?= htmlReady($name) ?>
diff --git a/templates/sidebar/select-widget.php b/templates/sidebar/select-widget.php
index 73d23156030..cadd2773267 100644
--- a/templates/sidebar/select-widget.php
+++ b/templates/sidebar/select-widget.php
@@ -2,7 +2,8 @@
<?= \SelectWidget::arrayToHiddenInput($params) ?>
<?= (strtolower($method) == 'post') ? CSRFProtection::tokenTag() : ''; ?>
<select class="sidebar-selectlist <?= $class ?> <? if ($__is_nested): ?>nested-select<? endif; ?>" <? !empty($size) ? printf('size="%u"', $size) : '' ?> <?= !empty($attributes) ? arrayToHtmlAttributes($attributes) : '' ?>
- name="<?= sprintf('%s%s', htmlReady($name), $multiple ? '[]' : '') ?>" <? if ($multiple) echo 'multiple'; ?>>
+ name="<?= sprintf('%s%s', htmlReady($name), $multiple ? '[]' : '') ?>" <? if ($multiple) echo 'multiple'; ?>
+ aria-label="<?= htmlReady($title) ?>">
<? foreach ($elements as $element): ?>
<? if ($element instanceof SelectGroupElement && count($element->getElements()) > 0): ?>
diff --git a/templates/sidebar/sidebar.php b/templates/sidebar/sidebar.php
index a624596e296..3c28062e8a5 100644
--- a/templates/sidebar/sidebar.php
+++ b/templates/sidebar/sidebar.php
@@ -1,5 +1,5 @@
<div id="layout-sidebar">
- <section class="sidebar">
+ <section class="sidebar" role="complementary" aria-label="<?= _('Seitenleiste') ?>">
<div class="sidebar-image <? if ($avatar) echo 'sidebar-image-with-context'; ?>">
<? if ($avatar) : ?>
<div class="sidebar-context">
--
GitLab