From ac38b6334e8da9a7d681fee207f9a92f5e54a74d Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+studip@gmail.com>
Date: Fri, 15 Jul 2022 12:16:59 +0000
Subject: [PATCH] fix missing variable, fixes #1336

Closes #1336

Merge request studip/studip!824
---
 app/controllers/materialien/files.php | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/app/controllers/materialien/files.php b/app/controllers/materialien/files.php
index d15061f0e73..629845a1bee 100644
--- a/app/controllers/materialien/files.php
+++ b/app/controllers/materialien/files.php
@@ -243,7 +243,6 @@ class Materialien_FilesController extends MVVController
             $this->response->add_header('X-Dialog-Execute', 'STUDIP.MVV.Document.reload_documenttable("' . $range_id . '", "' . $range_type . '")');
             $this->response->add_header('X-Dialog-Close', 1);
             $this->render_nothing();
-            return;
         }
     }
 
@@ -293,7 +292,6 @@ class Materialien_FilesController extends MVVController
             $this->response->add_header('X-Dialog-Execute', 'STUDIP.MVV.Document.reload_documenttable()');
             $this->response->add_header('X-Dialog-Close', 1);
             $this->render_nothing();
-            return;
         }
     }
 
@@ -438,7 +436,6 @@ class Materialien_FilesController extends MVVController
             $this->response->add_header('X-Dialog-Execute', 'STUDIP.MVV.Document.reload_documenttable("' . $range_id . '", "' . $range_type . '")');
             $this->response->add_header('X-Dialog-Close', 1);
             $this->render_nothing();
-            return;
         }
     }
 
@@ -466,7 +463,6 @@ class Materialien_FilesController extends MVVController
             $this->response->add_header('X-Dialog-Execute', 'STUDIP.MVV.Document.reload_documenttable("' . $range_id . '")');
             $this->response->add_header('X-Dialog-Close', 1);
             $this->render_nothing();
-            return;
         }
     }
 
@@ -481,10 +477,9 @@ class Materialien_FilesController extends MVVController
         PageLayout::postSuccess(_('Das Dokument und alle seine Zuweisungen wurden gelöscht.'));
 
         if (Request::isXhr()) {
-            $this->response->add_header('X-Dialog-Execute', 'STUDIP.MVV.Document.reload_documenttable("' . $range_id . '")');
+            $this->response->add_header('X-Dialog-Execute', 'STUDIP.MVV.Document.reload_documenttable()');
             $this->response->add_header('X-Dialog-Close', 1);
             $this->render_nothing();
-            return;
         }
     }
 
@@ -512,7 +507,6 @@ class Materialien_FilesController extends MVVController
 
         if (!Request::isXhr()) {
             $this->perform_relayed('index');
-            return;
         }
     }
 
-- 
GitLab