From 3cdc7aec2a55381010e8772c6a073142e03a7b70 Mon Sep 17 00:00:00 2001
From: Elmar Ludwig <elmar.ludwig@uni-osnabrueck.de>
Date: Mon, 8 Aug 2022 07:15:19 +0000
Subject: [PATCH] don't try to reimplement orderBy() in a broken way, fixes
#1410
Closes #1410
Merge request studip/studip!864
---
lib/models/Statusgruppen.php | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/lib/models/Statusgruppen.php b/lib/models/Statusgruppen.php
index a11e211f11d..03e57d2ab25 100644
--- a/lib/models/Statusgruppen.php
+++ b/lib/models/Statusgruppen.php
@@ -550,18 +550,14 @@ class Statusgruppen extends SimpleORMap implements PrivacyObject
*/
public function sortMembersAlphabetic()
{
- foreach ($this->members as $member) {
- $assoc[$member->id] = $member->user->nachname."_".$member->user->vorname;
- }
- asort($assoc);
-
$i = 0;
- foreach ($assoc as $key => $value) {
- $statusgruppenuser = new StatusgruppeUser(explode('_', $key));
- $statusgruppenuser->position = $i++;
- $statusgruppenuser->store();
+
+ foreach ($this->members->orderBy('nachname, vorname') as $member) {
+ $member->position = $i++;
+ $member->store();
}
}
+
/**
* Sorts subgroups alphabetical
*/
--
GitLab