From 2e7117b7c836e09ee5685ec584f339b6e4f6bedd Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+studip@gmail.com>
Date: Fri, 15 Jul 2022 18:56:15 +0000
Subject: [PATCH] don't assign by reference, declare filter variable, fixes
#1338
Closes #1338
Merge request studip/studip!826
---
app/controllers/resources/room_request.php | 2 ++
app/controllers/studip_controller.php | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/app/controllers/resources/room_request.php b/app/controllers/resources/room_request.php
index ca483d96301..af5958aca81 100644
--- a/app/controllers/resources/room_request.php
+++ b/app/controllers/resources/room_request.php
@@ -21,6 +21,8 @@
*/
class Resources_RoomRequestController extends AuthenticatedController
{
+ protected $filter;
+
public function before_filter(&$action, &$args)
{
parent::before_filter($action, $args);
diff --git a/app/controllers/studip_controller.php b/app/controllers/studip_controller.php
index a85e427e9f5..2966f3c02f1 100644
--- a/app/controllers/studip_controller.php
+++ b/app/controllers/studip_controller.php
@@ -234,7 +234,7 @@ abstract class StudipController extends Trails_Controller
$arg = $sorm;
if ($this->_autobind) {
- $this->{$info['var']} =& $arg;
+ $this->{$info['var']} = $arg;
}
break;
--
GitLab