diff --git a/app/controllers/admin/statusgroups.php b/app/controllers/admin/statusgroups.php
index a75d97e3e52b4b5a69cf2bc28a20194faa035eb5..6129e228f87193f535b1d4562857b7c98bdcbd6a 100644
--- a/app/controllers/admin/statusgroups.php
+++ b/app/controllers/admin/statusgroups.php
@@ -354,13 +354,10 @@ class Admin_StatusgroupsController extends AuthenticatedController
*/
private function setType()
{
-
- if (get_object_type(Context::getId(), ['inst', 'fak'])) {
- $type = 'inst';
- }
+ $type = Context::isInstitute() ? 'inst' : null;
$types = $this->types();
- if (!$type || Request::submitted('type') && $type != Request::get('type')) {
+ if (!$type || Request::submitted('type') && $type !== Request::get('type')) {
$types[Request::get('type', 'inst')]['redirect']();
} else {
$this->type = $types[$type];
diff --git a/lib/models/resources/ResourceRequest.class.php b/lib/models/resources/ResourceRequest.class.php
index d5217819094d7dd8f101fa6b63ad235016ad939d..dcbea9f01381d612ea1a64baad09aa823cb44593 100644
--- a/lib/models/resources/ResourceRequest.class.php
+++ b/lib/models/resources/ResourceRequest.class.php
@@ -1182,10 +1182,10 @@ class ResourceRequest extends SimpleORMap implements PrivacyObject, Studip\Calen
if ($with_range) {
$date = CourseDate::find($appointment->appointment_id);
- $interval['range'] = 'ResourceRequestAppointment';
+ $interval['range'] = ResourceRequestAppointment::class;
$interval['range_id'] = $appointment->appointment_id;
- $interval['booked_room'] = $date->room_booking->resource_id;
- $interval['booking_id'] = $date->room_booking->id;
+ $interval['booked_room'] = $date->room_booking ? $date->room_booking->resource_id : null;
+ $interval['booking_id'] = $date->room_booking ? $date->room_booking->id : null;
}
$time_intervals[] = $interval;
@@ -1207,7 +1207,7 @@ class ResourceRequest extends SimpleORMap implements PrivacyObject, Studip\Calen
];
}
if ($with_range) {
- $interval['range'] = 'CourseDate';
+ $interval['range'] = CourseDate::class;
$interval['range_id'] = $this->termin_id;
$interval['booked_room'] = $this->date->room_booking ? $this->date->room_booking->resource_id: null;
$interval['booking_id'] = $this->date->room_booking ? $this->date->room_booking->id : null;
@@ -1231,7 +1231,7 @@ class ResourceRequest extends SimpleORMap implements PrivacyObject, Studip\Calen
];
}
if ($with_range) {
- $interval['range'] = 'CourseDate';
+ $interval['range'] = CourseDate::class;
$interval['range_id'] = $date->id;
$interval['booked_room'] = $date->room_booking->resource_id;
$interval['booking_id'] = $date->room_booking->id;
@@ -1258,10 +1258,10 @@ class ResourceRequest extends SimpleORMap implements PrivacyObject, Studip\Calen
];
}
if ($with_range) {
- $interval['range'] = 'CourseDate';
+ $interval['range'] = CourseDate::class;
$interval['range_id'] = $date->id;
- $interval['booked_room'] = $date->room_booking->resource_id;
- $interval['booking_id'] = $date->room_booking->id;
+ $interval['booked_room'] = $date->room_booking ? $date->room_booking->resource_id: null;
+ $interval['booking_id'] = $date->room_booking ? $date->room_booking->id : null;
}
$time_intervals[] = $interval;
}
diff --git a/templates/widgets/widget-layout.php b/templates/widgets/widget-layout.php
index df3ff34b9dde0719150205c9349ad02a7fd42d74..48f91a67023156288739db1aac07f4f683085098 100644
--- a/templates/widgets/widget-layout.php
+++ b/templates/widgets/widget-layout.php
@@ -1,5 +1,5 @@
<div class="<?= $base_class ?>-widget <?= htmlReady(implode(' ', $layout_css_classes ?? [])) ?>">
-<? if ($title): ?>
+<? if (!empty($title)): ?>
<div class="<?= $base_class ?>-widget-header">
<?= htmlReady($title) ?>
</div>