From 2c31279a42b81ac49cb089e3ce6df72593eede6b Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+studip@gmail.com>
Date: Wed, 21 Dec 2022 09:58:33 +0000
Subject: [PATCH] add tooltip content as aria label, fixes #1916
Closes #1916
Merge request studip/studip!1267
---
resources/assets/javascripts/bootstrap/tooltip.js | 1 +
resources/assets/javascripts/lib/tooltip.js | 1 +
templates/shared/tooltip.php | 7 +++++++
3 files changed, 9 insertions(+)
diff --git a/resources/assets/javascripts/bootstrap/tooltip.js b/resources/assets/javascripts/bootstrap/tooltip.js
index c2493cf7456..449baccd51c 100644
--- a/resources/assets/javascripts/bootstrap/tooltip.js
+++ b/resources/assets/javascripts/bootstrap/tooltip.js
@@ -37,6 +37,7 @@ $(document).on('mouseenter mouseleave focusin focusout', '[data-tooltip],.toolti
}
$(this).attr('title', '');
$(this).attr('data-tooltip', content);
+ $(this).attr('aria-label', content);
tooltip = new STUDIP.Tooltip(x, y, content);
diff --git a/resources/assets/javascripts/lib/tooltip.js b/resources/assets/javascripts/lib/tooltip.js
index 5ae28edfd20..bf0e786ecf9 100644
--- a/resources/assets/javascripts/lib/tooltip.js
+++ b/resources/assets/javascripts/lib/tooltip.js
@@ -87,6 +87,7 @@ class Tooltip {
*
* @param {int} x - Horizontal offset
* @param {int} y - Vertical offset
+ * @param {bool} left_arrow - Vertical offset
*/
translateArrows(x, y, left_arrow = false) {
CSS.removeRule(`#${this.id}::before`);
diff --git a/templates/shared/tooltip.php b/templates/shared/tooltip.php
index a97c73f2759..af06bce8a5a 100644
--- a/templates/shared/tooltip.php
+++ b/templates/shared/tooltip.php
@@ -1,3 +1,10 @@
+<?php
+/**
+ * @var bool $html
+ * @var bool $important
+ * @var string $text
+ */
+?>
<span class="tooltip tooltip-icon <? if ($important) echo 'tooltip-important'; ?>" data-tooltip <? if (!$html) printf('title="%s"', htmlReady($text)) ?> tabindex="0">
<? if ($html): ?>
<span class="tooltip-content"><?= $text ?></span>
--
GitLab